Mustard2 / MustardSimplify

A scene simplifier for Blender to increase viewport performance
MIT License
54 stars 2 forks source link

UI fixes and improvements #27

Open cl3m3c7 opened 3 months ago

Mustard2 commented 3 months ago

Thanks! I'll test those and approve this :)

cl3m3c7 commented 3 months ago

and another thing, if you check simplify objects without checking modifiers (global options), an exception is being thrown, this line here is confusing to me! if objects requires modifiers to be enabled, then I think a little change in the poll function of MUSTARDSIMPLIFY_OT_SimplifyScene class might be needed, something like:

diff --git a/simplify/ops_simplify.py b/simplify/ops_simplify.py
index 7b052e0..557ec76 100644
--- a/simplify/ops_simplify.py
+++ b/simplify/ops_simplify.py
@@ -19,6 +19,8 @@ class MUSTARDSIMPLIFY_OT_SimplifyScene(bpy.types.Operator):
         settings = scene.MustardSimplify_Settings

         if not settings.simplify_status:
+            if settings.objects:
+                return settings.objects and settings.modifiers
             return settings.blender_simplify or settings.modifiers or settings.shape_keys or settings.physics or settings.drivers or settings.normals_auto_smooth
         else:
             return True
Mustard2 commented 3 months ago

I guess you're right, if you want change also this :)

Mustard2 commented 3 months ago

Waiting for the button thing, let's see if there's a way :)

cl3m3c7 commented 3 months ago

I think this should be pushed as the last bug fix release for the 4.1 channel! there is a new method added in 4.2, but I am not able to get the desired result, here it is if you want to play with it! https://projects.blender.org/blender/blender/pulls/124139

cl3m3c7 commented 3 months ago

also https://github.com/Mustard2/MustardSimplify/blob/d32be68f497fa664ec10f4507ac88f342be53bb4/simplify/ops_settings_blender_simplify.py#L40 and https://github.com/Mustard2/MustardSimplify/blob/d32be68f497fa664ec10f4507ac88f342be53bb4/simplify/ops_settings_blender_simplify.py#L57 blocks should be remove in the next release for 4.2. Read more

Mustard2 commented 2 months ago

Ah nice, I'll remove those then