search

Mutagen-Modding / Mutagen.Bethesda.Analyzers

A project to diagnose and analyze the health of a mod or a load order
GNU General Public License v3.0
18 stars 5 forks source link

New Analyzers #121

Closed Elscrux closed 2 months ago

Elscrux commented 2 months ago
Elscrux commented 2 months ago

Thanks for the PR! It's a great start to getting the analyzers project seeded!

Don't get too overwhelmed by the comments. Was working through some design waffling while making them. I think generally since most of the analyzers are marked DevelopmentTopic, we can just evaluate them in greater detail as we go to "upgrade" them to official stamped topics

Overall though, this PR's convinced me a bit more than we need sideloading. So ill be thinking on that more

There's a few comments that could be adjusted before we merge this in.. but the bulk is just discussion/musings

Thanks a lot for working through this massive PR. I appreciate all the suggestions!

Noggog commented 2 months ago

Also, from the #118 discussion

Gotcha. Might be nice to not have it so random. Maybe the TopicPrefix can be DEV Maybe we just modify TopicId to take in a string id, where the DevelopmentTopic passes in a string, but the FromDiscussion passes the int

Elscrux commented 2 months ago

Hmm, I dont necessarily mind the extensions living in their own namespace to match the folder they're in. IDEs will import them easily enough. If we dont want to have to do that, I think I'd prefer adding implicit namespaces to the project instead? Similar result, but without a Jetbrains specific file

https://devblogs.microsoft.com/dotnet/welcome-to-csharp-10/

Sounds good! Wasn't aware this is a JetBrains specific thing