Mutagen-Modding / Mutagen.Bethesda.Analyzers

A project to diagnose and analyze the health of a mod or a load order
GNU General Public License v3.0
14 stars 4 forks source link

Superfluous edits to Default object manager #37

Open MacSplody opened 3 years ago

MacSplody commented 3 years ago

The Default object manager DOBJ contains a list of objects which can be assigned a keyword. This record is merged at runtime, so it will take the last value assigned to each object. The correct way for a mod to make changes to the DOBJ, is to only add changes to specific objects.

Examples of incorrect edits. Universal Race Scale Remover SSE Killable Children

Examples of correct edits. IDRS - Improved Disabled Race Scaling Weapons Armor Clothing and Clutter Fixes

Noggog commented 3 years ago

Thanks for the issue @MacSplody! Might be good to snap specific examples in xedit and upload, as the mods in the links might change over time

Also, do you have any knowledge of what errors occur when done improperly? Just messy? CTD? Subtle bug in-game? I have no idea myself offhand

MacSplody commented 3 years ago

Might be good to snap specific examples in xedit and upload, as the mods in the links might change over time

I have one at hand already.

image

Also, do you have any knowledge of what errors occur when done improperly? Just messy? CTD? Subtle bug in-game? I have no idea myself offhand

No I haven't tested it myself, but I imagine it will break anything reliant on those keywords. Hard to say without knowing what the keyword effect, and then doing some testing.