Mutagen-Modding / Mutagen

A .NET library for analyzing, creating, and manipulating Bethesda mods
GNU General Public License v3.0
121 stars 32 forks source link

ActorValueInformation -> ActorValue mapping #464

Closed MarkKoz closed 1 year ago

MarkKoz commented 1 year ago

Closes #447

Implement a ActorValueMapper to map a ActorValueInformation record to the corresponding value in the ActorValue enum.

I exported the AVIF records from SSEEdit using a slightly modifed version of the QuickDisplay script from here. Then I imported the CSV into this script to generate the code.

MarkKoz commented 1 year ago

Some of these records are actually in SkyrimSE.exe. Does that mean the string given to the FormKey factory should use the exe instead of Skyrim.esm?

Noggog commented 1 year ago

Some of these records are actually in SkyrimSE.exe. Does that mean the string given to the FormKey factory should use the exe instead of Skyrim.esm?

Mutagen doesn't actually know about the records within Skyrim.exe at all. If it did, it probably would be hardcoded records defined by hand and included in Mutagen.Bethesda.Skyrim that were always resolvable? But would need to do more research on how those records behave. Can you override these records? Any other restrictions? #468

Anyway, for now, I think the records within Skyrim.exe can be viewed as non-existent

MarkKoz commented 1 year ago

I think Fallout 4 is better left for a separate issue/PR. The ActorValue enum itself is incorrect to begin with (it's just copied from Skyrim currently).