Mutagen-Modding / Mutagen

A .NET library for analyzing, creating, and manipulating Bethesda mods
GNU General Public License v3.0
121 stars 32 forks source link

Update Fallout 4's ActorValue Enum with Correct Values #473

Closed MarkKoz closed 1 year ago

MarkKoz commented 1 year ago

Currently, Fallout 4's ActorValue enum is just a copy of Skyrim's, which is not correct/appropriate for Fallout 4.

See the attached CSV files for AVIF records' form and editor IDs

DLCCoast.esm.csv DLCNukaWorld.esm.csv DLCRobot.esm.csv DLCworkshop01.esm.csv DLCworkshop02.esm.csv DLCworkshop03.esm.csv Fallout4.esm.csv Fallout4.exe.csv

Noggog commented 1 year ago

xEdit's definitions of the actor value enums are the same for Tes5 and Fallout4 Fo4: https://github.com/TES5Edit/TES5Edit/blob/dev-4.1.5/Core/wbDefinitionsFO4.pas#L8154 Tes5: https://github.com/TES5Edit/TES5Edit/blob/dev-4.1.5/Core/wbDefinitionsTES5.pas#L6103

Checked in notepad++ quickly, and they seem to be the same.

But thats the ActorValue enum, and the integer values that represent them on disk. That's different than the data you're posting, which is the ActorValueInformation Major Records. The values of the enum don't affect the setup of the major records, or vice versa, as far as I know. They're generally unrelated, which is why the mapping tech is needed #471

Can you go over what you think is wrong, specifically? What is a specific enum value that needs to be different, and for what reasoning?

MarkKoz commented 1 year ago

Sorry, I confused the relationship between the records and the enum. I was expecting a one to one mapping like I saw for Skyrim.