Mutagen-Modding / Mutagen

A .NET library for analyzing, creating, and manipulating Bethesda mods
GNU General Public License v3.0
115 stars 32 forks source link

Issue with plugin version 1.71; Plugins using the new Form space do not get copied or saved correctly when saving a plugin #509

Closed Michael-wigontherun closed 5 months ago

Michael-wigontherun commented 5 months ago

1.71 opened up the door for more esl forms, you have definitely been told about this repeatedly by others and excuse me if I am duplicating this issue as well, especially if this is specifically a Synthesis issue but it seems like its more an issue with Mutegen.

When Mutagen copies a form from that new esl space from 1.71. It looses the ModKey for the original plugin and defaults to Skyrim.esm. Synthesis generated patch:

image Original plugin, "Skyrim Food Expansion.esp" https://www.nexusmods.com/skyrimspecialedition/mods/110935:

image

And it becomes especially dangerous if it happens to be a FormID that actually overlaps with Skyrim.esm

Synthesis generated patch:

image Skyrim.esm

image Original plugin, "Skyrim Food Expansion.esp" https://www.nexusmods.com/skyrimspecialedition/mods/110935:

image

Skyrim Food Expansion and my SynNotSoSalty patcher were used if you wish to test and replicate it

I am using Synthesis version 0.26. And my patcher, SynNotSoSalty is already using the latest version of Mutegen v0.42.0 and Synthesis v0.26.0. I would consider this an urgent issue. And again I am sorry if this is a duplicate issue, I could not locate another issue with this direct issue.

Noggog commented 5 months ago

I think this is just because you were running /w mutagen versions that only output 1.7 headers, but Synthesis was pulling in mods /w 1.71 headers as inputs

Mutagen v0.43 and Synthesis v0.27 should hopefully fix your issue