Mutagen-Modding / Spriggit

A tool to facilitate converting Bethesda plugin files to a text based format that can be stored in Git
GNU General Public License v3.0
88 stars 10 forks source link

No warning when a form type is skipped #39

Closed Pickysaurus closed 9 months ago

Pickysaurus commented 9 months ago

Currently using Spriggit for the Community Patch.

Added a new form type Package (PACK) with 4 additional records.

Serialized the plugin.

No errors during serialisation. The total form count is updated but the PACK forms were omitted.

If Spriggit encounters a data type is can't decode it should throw and error and cancel the process. Had I not checked this, the mod could've been released with missing data.

To Replicate

Noggog commented 9 months ago

I think this is mostly a symptom of early days, since starfields not fully parsed https://github.com/Mutagen-Modding/Mutagen/issues/482

I think this concern will mostly be handled once things fill out, but also with #23, which will be concerned with detecting and reporting data loss during (de)serializations