Mutagen-Modding / Spriggit

A tool to facilitate converting Bethesda plugin files to a text based format that can be stored in Git
GNU General Public License v3.0
88 stars 10 forks source link

Conditions -> Unknown1 is some kind of unique user ID. #78

Closed gir489returns closed 1 month ago

gir489returns commented 1 month ago

I recently hired on a new programmer onto the Cheat Terminal team to take up some of the slack for the mod, as I have become jaded and aloofed from working on it. During his first commit, we had him simply load the mod into the Creation Kit, Save, and do a Spriggit -> Git just so I can show him the quirkly nature of this, and the inevitable code-review nightmare we're going to have to work with every time we save.

image

On top of the changes noted in #74, MenuItems -> Conditions -> Unknown1 changed when he saved. It was 0x911400, and his changed to 0x8F1400. When I loaded his branch into CK and did the same thing (Save -> Spriggit -> Git), it went from 0x8F1400 -> 0x911400. These random nonsensical changes as mentioned before make code reviewing an absolute headache.

Noggog commented 1 month ago

Thanks for the report! Looking at xEdit's definitions, they see it as nonsense data: image

For reference, here is mutagen's definition for it: image

I think it's more likely that it's "fluff" bytes that are simply not set by the CK at all and retain whatever memory values happen to exist there. I bet that it might change to other values if you tried again after restarting and/or poking the CK enough, though potentially not.

Either way, I can see about adding it to the Spriggit field ignore list!