Mutagen-Modding / Synthesis

A patcher pipeline framework and GUI. Run collections of code-based mods to create content customized for your load order
GNU General Public License v3.0
245 stars 18 forks source link

Synthesis can't read SSE Header 1.71 Extended ESL Range FormIDs properly (and subsequently can't create patches for them) #440

Closed HDMFanatic closed 7 months ago

HDMFanatic commented 7 months ago

Title says it all. Though it seems like the only way to fix it would be to make Synthesis generate Header 1.71 esp files, which would require users of SSE versions below 1.6.1130 to use nukem's Backported Extended ESL Support.

Example: If the AOS/ISC patcher is run with Einherjr in the load order Synthesis will mistake its Big Axe FormID for the WaterbreathingAV FormID, breaking that function. In general, it appears that any extended esl that has a similar FormID to a non-esl FormID will be mistaken as the non-ESL FormID.

Noggog commented 7 months ago

Mutagen v0.43 + Synthesis v0.27 should have 1.71 support. Are your patchers running against those versions and still having issues?

https://github.com/Mutagen-Modding/Synthesis/wiki/Versioning

HDMFanatic commented 7 months ago

Ah, seems this is my own fault. I'll try again with running all my patchers with the newest version. So long as they compile correctly.

HDMFanatic commented 7 months ago

Ah, seems like some patchers currently don't support the latest Mutagen and Synthesis versions. For those I've manually set to use a version prior.

Noggog commented 7 months ago

Ah, seems like some patchers currently don't support the latest Mutagen and Synthesis versions. For those I've manually set to use a version prior.

Ah yeah. They might need to do some code work to upgrade to the latest versions. no fun.

If you post the patchers in question here or in the discord, I can see about upgrading them and initiating PRs (I typically try to do that when I add breaking code changes)

Going to close this issue, for now. Feel free to hop on the discord and post about the patchers that need upgrading, or ping me on a github issue on their pages (if github allows the ping, haha)