MutinyWallet / mutiny-web

The frontend for Mutiny Wallet
https://app.mutinywallet.com
MIT License
175 stars 49 forks source link

feat: QR scanner should handle dynamic QR codes #874

Open oleonardolima opened 4 months ago

oleonardolima commented 4 months ago

It would be needed to work with offline e-cash notes after the support of https://github.com/MutinyWallet/mutiny-node/issues/1024

@futurepaul @benthecarman @benalleng I will try to give it a try after https://github.com/MutinyWallet/mutiny-node/issues/1024, but do you have any thoughts on this already ?

benthecarman commented 4 months ago

We use this library https://www.npmjs.com/package/qr-scanner not sure if it has support for animated QRs. Would rather not have to move to a different library for this

benthecarman commented 4 months ago

Maybe we figure out NFC support and only do OOB notes through that

oleonardolima commented 4 months ago

We use this library https://www.npmjs.com/package/qr-scanner not sure if it has support for animated QRs. Would rather not have to move to a different library for this

Cool, I'll take a look at this library

Maybe we figure out NFC support and only do OOB notes through that

Yes, that's a good approach as well

benthecarman commented 4 months ago

Here's how we could do NFC

https://capawesome.io/blog/announcing-the-capacitor-nfc-plugin/

oleonardolima commented 4 months ago

Here's how we could do NFC

https://capawesome.io/blog/announcing-the-capacitor-nfc-plugin/

Oh, wow!

oleonardolima commented 4 months ago

We use this library https://www.npmjs.com/package/qr-scanner not sure if it has support for animated QRs. Would rather not have to move to a different library for this

btw I was taking a better look at it and it's seems it's not supported https://github.com/nimiq/qr-scanner/issues/65

oleonardolima commented 4 months ago

Here's how we could do NFC

https://capawesome.io/blog/announcing-the-capacitor-nfc-plugin/

but even before the NFC support, we would need to have support for issuing oob notes / offilne ecash otherwise, there is no other wallet issuing ecash with NFC support 😅

oleonardolima commented 3 months ago

related resource: https://developer.blockchaincommons.com/animated-qrs/

extracted from cashu PR https://github.com/cashubtc/nuts/pull/31