search

MutopiaProject / mupub

A publication tool rewrite
MIT License
0 stars 2 forks source link

Support for python 3.4 subprocess module #1

Closed chrissawer closed 7 years ago

chrissawer commented 7 years ago

I am using mupub on a CentOS 7 machine which has Python 3.4 installed from EPEL. This is also the version of Python 3 which ships with Debian Jessie.

Unfortunately the subprocess module has changed between Python 3.4 and Python 3.5 and currently mupub relies on the Python 3.5 version.

Is it possible without too much work to replace the calls to subprocess.run in build.py and lily.py to remain compatible with Python 3.4? There is some guidance in the Python docs:

https://docs.python.org/3.5/library/subprocess.html#call-function-trio

glenl commented 7 years ago

I doubt this is much work at all. My strategy is to install 3.4 and force the virtual environment to that for development. I don't recall anything that depends on 3.5 features but I was unaware of this difference.

glenl commented 7 years ago

This was easy enough to fix and I've made a release (v0.4.1) with the changes. I've not tested it on 3.4 so please re-open it if still broken and I'll be more diligent regarding my development environment.

chrissawer commented 7 years ago

Fix looks good, thanks for the quick response. I have successfully built a piece using mupub on the Mutopia build server including RDF generation. I will continue to explore how it works over the next few days, and improve my understanding of the python code and tests. Then we can start deleting legacy code/scripts!