search

Muttley / foundryvtt-ac2d20

Achtung! Cthulhu 2d20 System for Foundry VTT
MIT License
4 stars 3 forks source link

Vehicle singleSeat quality fix #27

Closed lozanoje closed 6 months ago

lozanoje commented 10 months ago

Fix two issues:

  1. Key "AC2D20.VEHICLES.QUALITIES.singleSeat" is duplicated, I remove one.
  2. Vehicle quality "singleSeat:" changed for "singleSeat", there is an extra ":" at that label.
lozanoje commented 10 months ago

Seems that now quality singleSeat is duplicated, I have to further see whats happening

lozanoje commented 10 months ago

False alarm, the duplicated was because I had an old vehicle with the old "singleSeat:" label

Muttley commented 9 months ago

Unfortunately it's a bit more complicated than just changing the name. There needs to be a migration step written to automatically migrate the old named values to the new, otherwise some data could be lost.

Muttley commented 6 months ago

Fixed with the following commit: https://github.com/Muttley/foundryvtt-ac2d20/commit/d7172aca835cbf1c60b867a3d76a07334835415d