search

Mutual-Aid-Medford-and-Somerville / mamas-needs-offers

MIT License
0 stars 4 forks source link

add link to mamas homepage #10

Closed esetnik closed 4 years ago

esetnik commented 4 years ago

Closes #5

@mewtaylor not sure if this is what you had in mind. I made both the link and the logo image clickable.

Screen Shot 2020-04-04 at 12 59 03 AM
mewtaylor commented 4 years ago

@esetnik this is awesome! Only possible idea is that we change the text from the URL to "back to homepage" or "MAMAS homepage", since for the most part folks will be coming to the page from the main site. But I'd be curious to hear your thoughts and @mmoutenot 's thoughts on that.

esetnik commented 4 years ago

@esetnik this is awesome! Only possible idea is that we change the text from the URL to "back to homepage" or "MAMAS homepage", since for the most part folks will be coming to the page from the main site. But I'd be curious to hear your thoughts and @mmoutenot 's thoughts on that.

I usually like to show the url in links like this for two reasons:

  1. I don’t think we can assume the user came here from the homepage since this site could get shared around and ranked on google independently of the homepage. So for that reason I’d prefer to avoid the back language.
  2. For accessibility a screen reader will read out the title of the link and I’m afraid people who came here first won’t understand that this site isn’t the mamas homepage.

But I think using “MAMAS homepage” would also be a good option and it’s a quick change either way so I’ll defer to whatever you guys think is best. Just let me know if you want me to make that change.

mrshll commented 4 years ago

looks good -- merging. Thanks for the linting cleanup