Mutual-Aid-Medford-and-Somerville / mamas-needs-offers

MIT License
0 stars 4 forks source link

Updates styles on needs page to center header and filters #22

Closed dcalacci closed 4 years ago

dcalacci commented 4 years ago

addresses #21

dcalacci commented 4 years ago

regarding wrapping -- How do we want all these to be displayed on desktop and up? One simple way is to just fix button size and make it a grid under search.

esetnik commented 4 years ago

regarding wrapping -- How do we want all these to be displayed on desktop and up? One simple way is to just fix button size and make it a grid under search.

Makes sense to me. I actually think the new request action probably belongs on the right and the filters on the left. Not sure why but it makes more sense to me to have the majority of the controls left aligned. Also the button should be a different color or in some way indicate that it is different from the filter buttons.

dcalacci commented 4 years ago

just added a grid + flexbox fallback situation. looking at the commit its clear i'm not following whatever style guidelines are there (my editor has its own defaults) so happy to change if there's a guide somewhere

esetnik commented 4 years ago

just added a grid + flexbox fallback situation. looking at the commit its clear i'm not following whatever style guidelines are there (my editor has its own defaults) so happy to change if there's a guide somewhere

Please use prettier. See https://github.com/mmoutenot/mamas-needs-offers/blob/master/.prettierrc for our ruleset.

dcalacci commented 4 years ago

sorry about the mess. should be up to date. here's how it looks.

desktop

Screen Shot 2020-04-16 at 2 37 48 PM

tablet:

Screen Shot 2020-04-16 at 4 07 31 PM

mobile (wide)

Screen Shot 2020-04-16 at 4 07 47 PM

mobile

Screen Shot 2020-04-16 at 4 09 57 PM
esetnik commented 4 years ago

Looks good to me. Definitely better than what we have now. @mewtaylor any feedback you want to add? If anything I think the search bar belongs above the other filters rather than with the new button because it’s kind of a filter.

esetnik commented 4 years ago

@dcalacci do you mind rebasing this when you get a chance?