Muushy / Sprocket-Feedback

Report bugs or suggest features for Sprocket.
4 stars 0 forks source link

Era UI not syncing correctly when using custom eras #671

Open TheUltimateBreadLord opened 1 month ago

TheUltimateBreadLord commented 1 month ago

Describe the bug Sorry if there's anything wrong since this is my first bug report. I'll divide this report into 2 separate sections for each bug. Also these are in the 0.2 alpha sorry I didn't mark it but I don't know how to.

Bug 1. Custom era resetting visually after test driving or reloading the game.

Basically when you create a custom era using the feature added in 0.2.18 and make a vehicle using that era, whenever you test drive it or reload the game the era changes to WWI. What is important is that the change is only visual and doesn't affect the performance of the tank or any of the values (e.g engine hp output) and only changes it visually.

Bug 2. Vehicle not loading if cannon operating pressure is greater than ~65000 psi (might be more than that but 65000 is safe since 70000 causes the vehicle to not load.)

If you go to file edit the era the vehicle is in (can be custom era but vehicle's file also works) and set the cannon operating pressure value to more than ~65000 the tank does not load when you reload it or reload the game. This isn't exacty game breaking but it would be nice to have an ability to change it to a greater value to make guns with more penetration and muzzle velocity.

Version 0.2.20

To Reproduce Steps to reproduce the behavior: Bug 1.

  1. Go to 'D:\Steam\steamapps\common\Sprocket\Sprocket_Data\StreamingAssets\Technology' and 'D:\Steam\steamapps\common\Sprocket\Sprocket_Data\StreamingAssets\Eras' and create a new era as intended.
  2. In game make a vehicle using said custom era.
  3. Press space to test drive the tank or reload the game.
  4. After reloading or finishing the test drive the era should visually change to WWI.

Bug 2.

  1. Go to 'D:\Steam\steamapps\common\Sprocket\Sprocket_Data\StreamingAssets\Technology'
  2. Click on custom era 'cannon' file (or regular era's one. I don't think that matters) (e.g ModernCannon.json)
  3. change the "operatingPressure" value to something greater than 65000.
  4. After loading a vehicle using this era it should either not load at all or display as nothing.

Expected behavior What I would like to be done (obviously if possible) is to make it so that the custom era displays as the proper selected one after reloading the tank and also to make it possible to set the operating pressure of the gun to some way way bigger value so that we can have 120mm guns with like 650mm pen and 1500m/s velocity or even more.

Screenshots I don't think screenshots would help here especially with the first issue as a recording of it would be better, but I can provide more screenshots or recordings if necessary.

Additional context Last thing I'd like to say is thank you for developing Sprocket and putting so much effort into it, giving us so much freedom with our own tanks. This is truly one of my favourite games out there and I really can't wait for more updates and content.

DarioXN commented 4 weeks ago

Bug 2 is due to 65535 being the maximum possible value for an unsigned 16-bit integer.