search

MvvmCross / MvvmCross-AndroidSupport

Android support library packages for MvvmCross: The .NET MVVM framework for cross-platform solutions.
http://mvvmcross.com
15 stars 0 forks source link

Make IMvxRecyclerViewHolder methods virtual, in class MvxRecyclerViewHolder #279

Closed zleao closed 8 years ago

martijn00 commented 8 years ago

We can accept the changes, but please use the same formatting ;)

zleao commented 8 years ago

Sorry. I made the change in VS2015 and when I compared the files, it looks ok. Only 3 lines edit. But when I do the commit/sync and then go to the github site, he assumes that the whole file was change (formatting). Not sure how to prevent this from happening...

On Mon, Jul 25, 2016 at 1:45 PM, Martijn van Dijk notifications@github.com wrote:

We can accept the changes, but please use the same formatting ;)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MvvmCross/MvvmCross-AndroidSupport/pull/279#issuecomment-234931441, or mute the thread https://github.com/notifications/unsubscribe-auth/ADClSgBZu-vH_OiGLQhbPVEz-NBKjuV3ks5qZKHEgaJpZM4JUCcF .

martijn00 commented 8 years ago

Don't worry, i'll just merged it, we'll fix the formatting some time.

kjeremy commented 8 years ago

Looks like line ending changes to me. I'll pull in the .gitattributes from MvvmCross so we're at least consistent between projects.

zleao commented 8 years ago

I'm doing the changes directly in github site. i'll commit them in a sec...

On Mon, Jul 25, 2016 at 2:09 PM, Martijn van Dijk notifications@github.com wrote:

Don't worry, i'll just merged it, we'll fix the formatting some time.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MvvmCross/MvvmCross-AndroidSupport/pull/279#issuecomment-234935757, or mute the thread https://github.com/notifications/unsubscribe-auth/ADClSjbYl7zqSAPEq85iEVVkgFGcWbkmks5qZKdygaJpZM4JUCcF .

kjeremy commented 8 years ago

Don't do that. Make sure they compile on your machine first. Though it looks like @martijn00 already merged.

martijn00 commented 8 years ago

Hehe, yeah i already merged. But the .gitattributes sounds good! Could you also add that to the other repos @kjeremy ?

zleao commented 8 years ago

Yep. already merged :) Thanks!

On Mon, Jul 25, 2016 at 2:11 PM, Martijn van Dijk notifications@github.com wrote:

Hehe, yeah i already merged. But the .gitattributes sounds good! Could you also add that to the other repos @kjeremy https://github.com/kjeremy ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MvvmCross/MvvmCross-AndroidSupport/pull/279#issuecomment-234936207, or mute the thread https://github.com/notifications/unsubscribe-auth/ADClSq-C54Lx7mVzz2MwXSkRruPUjM0pks5qZKgGgaJpZM4JUCcF .