search

MvvmCross / MvvmCross-AndroidSupport

Android support library packages for MvvmCross: The .NET MVVM framework for cross-platform solutions.
http://mvvmcross.com
15 stars 0 forks source link

Updated MvxRecyclerView #281

Closed Johan-dutoit closed 8 years ago

Johan-dutoit commented 8 years ago

Allows the user to override the LayoutManager used.

martijn00 commented 8 years ago

I am not seeing why this should be changed. It currently is possible to set the layoutmanager with SetLayoutManager

Johan-dutoit commented 8 years ago

That is correct, however do we want it to create two layout managers?

The one in the constructor and the other when we call SetLayoutManager.

On 29 Jul 2016 12:57, "Martijn van Dijk" notifications@github.com wrote:

I am not seeing why this should be changed. It currently is possible to set the layoutmanager with SetLayoutManager

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MvvmCross/MvvmCross-AndroidSupport/pull/281#issuecomment-236162401, or mute the thread https://github.com/notifications/unsubscribe-auth/ABiVL4vfyIL6Cn_Hea889tukinPYR2eoks5qaeq4gaJpZM4JYFqB .

kjeremy commented 8 years ago

I don't understand this change. Isn't LayoutManager null in the constructor?

Johan-dutoit commented 8 years ago

There is a new virtual property that creates it? Which the user can override to whatever they want?

Instead of having the new in the 'ctor' and then again when calling 'SetLayoutManager'.

On 29 Jul 2016 1:19 p.m., "Jeremy Kolb" notifications@github.com wrote:

I don't understand this change. Isn't LayoutManager null in the constructor?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MvvmCross/MvvmCross-AndroidSupport/pull/281#issuecomment-236166081, or mute the thread https://github.com/notifications/unsubscribe-auth/ABiVL9p5IZXgcewP9DeF4-F7akP_aDVbks5qae_HgaJpZM4JYFqB .