search

MvvmCross / MvvmCross-AndroidSupport

Android support library packages for MvvmCross: The .NET MVVM framework for cross-platform solutions.
http://mvvmcross.com
15 stars 0 forks source link

Fix Memory Issues #300

Closed kjeremy closed 7 years ago

kjeremy commented 7 years ago

This PR corresponds with https://github.com/MvvmCross/MvvmCross/pull/1446 and should be pulled in after that change is accepted.

Together these two PRS fix: https://github.com/MvvmCross/MvvmCross/issues/1444 https://github.com/MvvmCross/MvvmCross/issues/1405

280

inormis commented 7 years ago

@kjeremy how to understand when this fix will be released?

kjeremy commented 7 years ago

It's in the latest release. Please make sure you are using the latest MvvmCross.

On Dec 5, 2016 5:42 AM, "Artiom K" notifications@github.com wrote:

@kjeremy https://github.com/kjeremy how to understand when this fix will be released?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MvvmCross/MvvmCross-AndroidSupport/pull/300#issuecomment-264821575, or mute the thread https://github.com/notifications/unsubscribe-auth/AEIBRDAlfYFTDw_SHBP44pSvCWoIlaPeks5rE-qMgaJpZM4KMNPA .

inormis commented 7 years ago

We are using v4.3. I was sure my colleague has updated MVVMCross to 4.4 version. I'll upgrade it and will come back in 1-2 days with news. Thank you!

inormis commented 7 years ago

@kjeremy it's still reproducible. But can it be caused by our implementation?

Our Viewmodels for fragments and tabs derive from MvxViewModel. But we also have viewmodels for children objects (for example ViewModel that exposes exchange rates). They derive from our BaseNotificationViewModel (it came from Desktop app). It provides RaisePropertyChanged methods that invoke PropertyChanged events (nothing more). Most of the frequent property changes are done using BaseNotificationViewModel. So, can it lead to bug with SetTextFormatted?

kjeremy commented 7 years ago

This is a pull request, not an issue, so I'm not quite sure what you are seeing. Please open a new issue and point to me to a reproducible test case and I will investigate.