MvvmCross / MvvmCross-Forms

Support for Xamarin.Forms on MvvmCross: The .NET MVVM framework for cross-platform solutions, including Xamarin.iOS, Xamarin.Android, Windows and Mac.
http://mvvmcross.com
6 stars 2 forks source link

Fixes for #45 #46

Closed Cheesebaron closed 8 years ago

Cheesebaron commented 8 years ago

This PR fixes where the Forms presenter finds its Pages. It was looking at the Assembly where the ViewModel's were in before, which was incorrect. Now it uses IMvxViewsContainer which allows the dev to override how they are found by either overriding GetViewsAssemblies or InitializeViewLookup.

This PR also fixes issues with the Show method in the Forms presenter. Show method is not awaited by MvvmCross. It was marked async void before, so code continued to run even though someone would expect it not to. This means there were issues with AppDelegate on iOS where FinishedLaunching expects something to be presented at the end of it. However, in some cases this would not happen because the async method had not yet finished finding a page etc.

This affects #45