search

Mwexim / skript-parser

A standalone and improved implementation of the Skript language for use outside of Minecraft servers.
MIT License
49 stars 15 forks source link

Suggestion for PropertyExpression#toString() #121

Closed Anarchick closed 3 years ago

Anarchick commented 3 years ago

Hi, I suggest this only for propertyExpression ,

https://github.com/SkriptLang/skript-parser/blob/911bb911195c1ba3f02ed5024e8d385faa5dd1d9/src/main/java/io/github/syst3ms/skriptparser/expressions/ExprLength.java

The toString() is really needed ? It can't be write in the abstract class ?

You can @override only if needed or use default ... of ...

WeeskyBDW commented 3 years ago

I suggest using property expression name (property) if it's done

Mwexim commented 3 years ago

I actually was working on this already, but didn’t have time to finish it. It will certainly be added!