search

Mwexim / skript-parser

A standalone and improved implementation of the Skript language for use outside of Minecraft servers.
MIT License
49 stars 15 forks source link

Update broken gradle wrapper to 8.3 #137

Closed TheLimeGlass closed 1 year ago

TheLimeGlass commented 1 year ago

Updates the gradle wrapper to 8.3 so Java 17 machines can build the source. This pull request updates the wrapper to gradle version 8.3 (latest stable at the time of this pull request).

The gradle wrapper is essential to development so that everyone working on the project is using the same gradle version with the gradlew rather than random versions between developers.

Mwexim commented 1 year ago

I'm going to be honest, I have no idea what changed here. I understand that the Gradle version needs to be updated to support new Java version, but what did you actually change in the gradlew files? That said, I remember that a lot of Gradle files are just pre-generated stuff. I'll be happy to merge this pull request if that's the case.

TheLimeGlass commented 1 year ago

It's always good to keep gradle updated.

GitHub has a security action to ensure that gradlew files are not contained with malicious code aswell. See https://github.com/gradle/wrapper-validation-action

TheLimeGlass commented 1 year ago

I'll add GitHub's gradlew validation tool to this pull since I mentioned it. Good for security.