search

Mwexim / skript-parser

A standalone and improved implementation of the Skript language for use outside of Minecraft servers.
MIT License
49 stars 15 forks source link

Allow for a default on the isSingle #144

Closed TheLimeGlass closed 11 months ago

TheLimeGlass commented 1 year ago

Allow for a default on the isSingle on expression registration. This is because it's confusing to register the isSingle in the method registration if the class is guaranteed to override the isSingle method. This allows for no specification to signify that the class is going to override the isSingle.

Mwexim commented 1 year ago

I'm not sure how fond I am of this little addition. The SkriptRegistration class is already heavily cluttered with registration methods for convenience (partly my fault), so this would add one to the list.

That said, I was planning on refactoring some registration methods into that class (like the converters and comparators) so that everything is in one place. I'll take a look and let you know how I ultimately feel about it.