search

MxUI / MUI

Multiscale Universal Interface: A Concurrent Framework for Coupling Heterogeneous Solvers
http://mxui.github.io/
Apache License 2.0
54 stars 40 forks source link

Implement smoothing function on RBF spatial sampler #71

Closed Wendi-L closed 3 years ago

Wendi-L commented 3 years ago

Shepard's smoothing function has been implemented to construct the transformation matrix (H matrix) on the RBF spatial sampler.

Currently, the smoothing function is automatically applied to all modes (i.e. consistent/conservative; with or without polynomials). It can be modified later on if there is a need to let users decide whether to use the smoothing function or not.

SLongshaw commented 3 years ago

Hi Wendi,

Before accepting this my feeling is that it should be parameterised from the outset, apologies, looking at the code I realise this is more work than just adding a few if/else statements and a new instantiation parameter for the filter but I think it's worthwhile exposing this an an option early on.

I'm going to close this request with this comment but if adding the ability to switch smoothing on/off isn't feasible then please re-create the pull request and we can note it as an urgent future development.

Wendi-L commented 3 years ago

Hi Stephen, Yes, I agree. Will do it this week.