As described in issue #616 the column mlf2_entries.email_notifications is a leftover of a basic feature, that was overhauled and replaced in PR #399 with version 2.4.14. While the column was removed in the upgrade script, it remained in the installation script and was removed from there with version 2.4.22. The branch of the development for version 2.5 was splitted from the 2.4-branch after the release of 2.4.19.1. The fix in version 2.4.22 was not forward ported and the column remained therefore and made me fixing something that shouldn't exist anymore in PR #613.
This PR removes the column from the installation script and from the function deleteUser and checks for its existence in the upgrade script to remove it from the table mlf2_entries if necessary.
loesler
commented
2 years ago
As described in issue #616 the column
mlf2_entries.email_notificationsis a leftover of a basic feature, that was overhauled and replaced in PR #399 with version 2.4.14. While the column was removed in the upgrade script, it remained in the installation script and was removed from there with version 2.4.22. The branch of the development for version 2.5 was splitted from the 2.4-branch after the release of 2.4.19.1. The fix in version 2.4.22 was not forward ported and the column remained therefore and made me fixing something that shouldn't exist anymore in PR #613.This PR removes the column from the installation script and from the function
deleteUserand checks for its existence in the upgrade script to remove it from the tablemlf2_entriesif necessary.Fixes #616, if accepted.