My-Little-Forum / mylittleforum

A simple PHP and MySQL based internet forum that displays the messages in classical threaded view (tree structure)
GNU General Public License v3.0
121 stars 47 forks source link

Make the existing paginations more consistent #652

Closed auge8472 closed 1 year ago

auge8472 commented 1 year ago

In the context of my proposal in #651 I want to make the already existing pagination-link-lists more consistent. This means, that in the case of displaying the pagination on a certain page (user list, a users entries list and so on) a pagination will be displayed above and below the content in question.

Beside this change in itself I want to change a few things around. I'll document all changes, when the PR will be ready for review and rebase.

auge8472 commented 1 year ago

What I've done:

I loaded the changes up to the project forum for testing. Because these changes affecting only the theme (beside the additions in the language files for the headings), there is no damaging impact to the forum code in itself.

loesler commented 1 year ago

I updated my forum and it seems to work fine. I only had to adjust the language files because the time format was/is wrong in this PR. I wonder why this does not cause conflict.

auge8472 commented 1 year ago

I only had to adjust the language files because the time format was/is wrong in this PR.

This is, because I didn't rebase the latest changes in master to my PR. My fault.

I wonder why this does not cause conflict.

I think, there is no conflict, because my changes to the language files does affect completetly different regions in the files than your changes regarding the date format.

I will rebase my branch to include the latest changes in the master branch.