search

My-Little-Forum / mylittleforum

A simple PHP and MySQL based internet forum that displays the messages in classical threaded view (tree structure)
GNU General Public License v3.0
122 stars 48 forks source link

imagerotate does not return an image in certain cases, no error handling #658

Closed auge8472 closed 7 months ago

auge8472 commented 1 year ago

In certain cases the function imagerotate, utilised in the function create_image in modules/captcha/captcha.php does not return an image in case of the angle value of 180 degrees (second function parameter). Independently from solving the possible bug itself (there is none in a first sight) we basically need an error handling (handling of the value false). What should be done, if the fuction fails? IMHO the unrotated image should be used instead.

See therefore this thread in the project forum

loesler commented 1 year ago

I do not use this feature Do we really need it anymore (accessibility)?

auge8472 commented 1 year ago

I do not use this feature. Do we really need it anymore (accessibility)?

See therfore my new reply to the discussion previously linked above. :-)

vihuna commented 1 year ago

I have tested the changes made in PR #668: they seem to solve the problem, at least in my case, whatever the problem with imagerotate + 180º was.

auge8472 commented 1 year ago

@vihuna Thank you for your effort. I'll merge the change today in the evening (CET).

auge8472 commented 7 months ago

I'll close this issue for now. We'll have a release, that includes the changes of the corresponding PR #668 within the next days. If we get a report about ongoing errors, we can reopen this issue or open a new one.