Customized Alerts are unregistered when deactivate MyAlerts

[WhiteNeo]

I have a lot of tests and well now i have this error when you deactivate MyAlerts if you have some other alerts customized, then activate MyAlerts again and you've got an error even and alerts are on cache stored, well the code to register formated alerts won't work and an error appear on forum, if you go to index then new customized alerts are not registered and the new class is not extended to set the new one alert.

Only this error is on this cases, but if you uninstall and install again plugin (MyAlerts) and then activate or install again new plugins with customized alerts all goes fine again :D

I think there are something to do, anyway i do a better plugins with an options to load more fine new customized alerts, anyway i think there's a way to do to fix this with this code, i was share my plugins on development but i have a latest revision and now goes fine, but there's only that error, thanks in advance for all your hard and awesome job !!!!!!

[euantorano]

Hi, what is the error message?

On 20 Jan 2015, at 01:48, DNT notifications@github.com wrote:

I have a lot of tests and well now i have this error when you deactivate MyAlerts if you have some other alerts customized, then activate MyAlerts again and you've got an error even and alerts are on cache stored, well the code to register formated alerts won't work and an error appear on forum, if you go to index then new customized alerts are not registered and the new class is not extended to set the new one alert.

Only this error is on this cases, but if you uninstall and install again plugin (MyAlerts) and then activate or install again new plugins with customized alerts all goes fine again :D

I think there are something to do, anyway i do a better plugins with an options to load more fine new customized alerts, anyway i think there's a way to do to fix this with this code, i was share my plugins on development but i have a latest revision and now goes fine, but there's only that error, thanks in advance for all your hard and awesome job !!!!!!

— Reply to this email directly or view it on GitHub.

[WhiteNeo]

Fatal error: Class 'MyCustomAlertFormatter' not found in "mypluginfile" on line "line of register formmater"

In that lines i call on global_start for:

$formatterManager = MybbStuff_MyAlerts_AlertFormatterManager::getInstance(); $formatterManager->registerFormatter(new MyCustomAlertFormatter($mybb, $lang, 'customcode'));

But this error dissapear if i run deactivate and activate plugins with custom alerts again, even if this reoutine do nothing.

And only appears when i deactivate MyAlerts and Activate again,(only in that cases if you deactivate and activate new plugins all goes fine "again").

[euantorano]

Does that class definitely exist and is it loaded?

On 20 Jan 2015, at 20:41, DNT notifications@github.com wrote:

Fatal error: Class 'MyCustomAlertFormatter' not found in "mypluginfile" on line "line of register formmater"

In that lines i call on global_start for:

$formatterManager = MybbStuff_MyAlerts_AlertFormatterManager::getInstance(); $formatterManager->registerFormatter(new MyCustomAlertFormatter($mybb, $lang, 'customcode'));

But this error dissapear if i run deactivate and activate plugins with custom alerts again, even if this reoutine do nothing.

And only appears when i deactivate MyAlerts and Activate again,(only in that cases if you deactivate and activate new plugins all goes fine "again").

— Reply to this email directly or view it on GitHub.

[WhiteNeo]

Class exist and when try to load is when error happens, maybe an error on MyBB core or something, because when i run deactivate and activate routine without any code inside of the plugin is when all works fine again, because all works so fine by default.

[euantorano]

Can you post either the code you are using or a link to the code?

[WhiteNeo]

https://github.com/WhiteNeo/thankyou-mybb-system-mybb18x-series

This is my repo of plugin, but is on developlement i found a way to not shows whitescreen.

I use on inc/plugins/thx.php all entire code. Thanks for your response, and i still working on some things.

Another lesser issue is myalerts_scripts template is marked like bad code on MyBB review of templates but it's only for the name i change it to myalerts_js_popup and all goes fine, even i add another code because yours is marked as potential risk of security on MyBB (But is for the name scripts).

If you wish i send you the code i use to all plugin used only for MyAlerts compatibyllity.

[WhiteNeo]

Ok Euan today i make some test with latest 2.0.3 version and all seems to be fine now :dancer: I added new code improvements and alerts are loaded even if deactivate MyAlerts and activate again, or if uninstall and install again i add a subroutine on mine mod to load with a click MyAlerts integration and all goes fine now.

Can you add this mod to MyAlerts list of mods compat list on your wiki ?

https://github.com/WhiteNeo/thankyou-mybb-system-mybb18x-series

Thank You you can close this issue...

[euantorano]

Will do, glad it's sorted. I'm on a train at the minute, but I'll add it when I get home.

On 10 Sep 2015, at 17:16, DNT notifications@github.com wrote:

Ok Euan today i make some test with latest 2.0.3 version and all seems to be fine now
I added new code improvements and alerts are loaded even if deactivate MyAlerts and activate again, or if uninstall and install again i add a subroutine on mine mod to load with a click MyAlerts integration and all goes fine now.

Can you add this mod to MyAlerts list of mods compat list on your wiki ?

https://github.com/WhiteNeo/thankyou-mybb-system-mybb18x-series

Thank You you can close this issue...

— Reply to this email directly or view it on GitHub.