Fix #278: Warnings are emitted under PHP 8

[lairdshaw]

Also includes fixes for a few warnings (and potential warnings) not mentioned in the Community Forums post linked from issue #278.

Resolves #278

[euantorano]

Looks good, thanks. Just a minor suggestion/comment.

[euantorano]

We can do without in that case then, I’m happy to merge this and will do so shortly. On 12 Apr 2023, at 17:55, Laird @.***> wrote: @lairdshaw commented on this pull request.

In inc/plugins/myalerts.php:

@@ -723,9 +728,12 @@ function myalerts_global_start() $lang->load('myalerts'); }

• $mybb->user['myalerts_disabled_alert_types'] = json_decode(
• $mybb->user['myalerts_disabled_alert_types']
• );
• if (!empty($mybb->user['myalerts_disabled_alert_types']))
• {
• $mybb->user['myalerts_disabled_alert_types'] = json_decode(
• $mybb->user['myalerts_disabled_alert_types']
• );
• }

I'd wondered the same thing, and concluded that because the else below, on line 745, already handles that scenario, the redundancy wasn't worth it. Other than redundancy, though, it seems harmless to me, so, if you prefer to add it, I'll happily commit your suggestion. Just let me know.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>