search

MyBBStuff / MyAlerts

A simple notification/alert system for MyBB similar to IPB and XenForo's core implementations of user notifications.
http://www.euantor.com/myalerts/
47 stars 33 forks source link

Fix #293: The "Who's online" location is broken #294

Closed lairdshaw closed 1 year ago

lairdshaw commented 1 year ago

Resolves #293

Supersedes #266 (There's nothing especially wrong with that PR except for its minor failure to remove a mistaken define of NO_ONLINE; I just happened to implement my own fix in the course of all the other fixes I'm submitting tonight).

This PR honours the comment @euantorano made here indicating that a location should be set for the modal. There is, then, never any reason to define NO_ONLINE for any functionality of this plugin.

Eldenroot commented 1 year ago

@euantorano - please, could you merge these PRs?

@lairdshaw - thank you so much for your time and PRs! I am waiting for the updated version, or your fork :)

euantorano commented 1 year ago

I’ll review as soon as I can. I’ve been very busy the last few weeks, but hoping I’ll get a chance to review this week. On 18 Jun 2023, at 21:12, Eldenroot @.***> wrote: @euantorano - please, could you merge these PRs? @lairdshaw - thank you so much for your time and PRs! I am waiting for the updated version, or your fork :)

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

Eldenroot commented 1 year ago

@euantorano - OK, sounds good! I am asking because more PRs with fixes are under the way and we are waiting for you to merge these 8 opened PRs...