Change Asset Collateral Structure

MyBitIO commented 4 years ago

I want to propose a change to the asset collateral structure of mybit. Right now putting down 100%+ of the asset value doesn't incentivise people to list anything, bc they can just go purchase it on their own if they already have to put down the same amount or more as collateral.

So I want to change it back to what I initially proposed where it is free market. I.e the asset manager can put down any amount of collateral they want.

To update.

When listing an asset, a user can choose to put down any amount of collateral they want. From 0% to Infinite Amount.
This also needs to be displayed on the asset details page. i.e what % of the asset value has been put down as collateral.
Same model as currently for withdrawing collateral (4 increments, each at 25% intervals of revenue generated) - just make sure when you make the changes you don't break this component.

Notes: On the smart contract side of things it should just require a call to setCollateralLevels() on the Platform contract.

After implementing the changes, they must be deployed live and tested to ensure they satisfy this task.

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 200.0 DAI (200.0 USD @ $1.0/DAI) attached to it.

If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
- Want to chip in? Add your own contribution here.
- Questions? Checkout Gitcoin Help or the Gitcoin Slack
- $94,832.44 more funded OSS Work available on the Gitcoin Issue Explorer

emmaodia commented 4 years ago

@MyBitIO Kindly approve my request to start work.

gitcoinbot commented 4 years ago

@emmaodia Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

@emmaodia Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

emmaodia commented 4 years ago

Yes. I'm still working on this. Thanks. @MyBitIO I need help running the app on my local machine. Can you kindly give me an example env file in a github gist. Thanks.

gitcoinbot commented 4 years ago

@emmaodia Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

@emmaodia Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@emmaodia due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

[x] reminder (3 days)
[x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

emmaodia commented 4 years ago

I'm going to get the task done. I'm getting my Civic ID approved. I will give an update in another day. Thanks!

gitcoinbot commented 4 years ago

@emmaodia Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

@emmaodia Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

emmaodia commented 4 years ago

Hi. Getting Civic App ID approved is a bit of a chore due to the holidays. Will revert ASAP after the New Year holidays. Thank you for your patience.

gitcoinbot commented 4 years ago

@emmaodia Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

@emmaodia Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

emmaodia commented 4 years ago

Yes.

gitcoinbot commented 4 years ago

@emmaodia Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

@emmaodia Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

emmaodia commented 4 years ago

@MyBitIO I'm having a hard time getting Civic to verify my credentials on their app. This is the only thing stalling completion.

cryptnotiq commented 4 years ago

Civic shouldn't be a requirement if you are cloning from the most recent master branch where Civic was removed in this bounty: https://gitcoin.co/issue/MyBitFoundation/MyBit-Go.app/515/3801 - it is not yet in production on the main URL but if you clone and run locally it shouldn't be a requirement to have civic. @emmaodia sorry but it's been over a month on this bounty so we had to remove you from it and leave it open for someone else to do.

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 450.0 DAI (450.0 USD @ $1.0/DAI) attached to it.

If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
- Want to chip in? Add your own contribution here.
- Questions? Checkout Gitcoin Help or the Gitcoin Slack
- $78,827.37 more funded OSS Work available on the Gitcoin Issue Explorer

mul1sh commented 4 years ago

Hey @cryptnotiq @MyBitIO after installing the node_modules and running yarn dev i'm getting the attached error because the project is missing the lib folder, any thoughts on how to best sort this thanks?

uivlis commented 4 years ago

@mul1sh That's the exact same problem that I encountered, and, when asked about it, got removed from the bounty.

mul1sh commented 4 years ago

@uivlis wow ok then! Though after poking around I realized the command yarn compile-server is the one that generates the lib folder, this should be well documented.

But after running yarn dev I now get a new error

Error: Cannot find module './controllers/civicController'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
    at Function.Module._load (internal/modules/cjs/loader.js:562:25)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (/Users/mulish/Desktop/gitcoin/MyBit-Go.app/lib/index.js:7:47)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
error Command failed with exit code 1.

Should I go ahead and remove this line @MyBitIO @cryptnotiq @Mybit @MyBitFoundation

Also are there any test aws or airtable accounts I can use? They seem to be required

cryptnotiq commented 4 years ago

@mul1sh yes go ahead.

mul1sh commented 4 years ago

@cryptnotiq thanks

cryptnotiq commented 4 years ago

@mul1sh how is this coming along?

mul1sh commented 4 years ago

An update, just testing my changes and then I submit the PR.

cryptnotiq commented 4 years ago

Could you please coordinate with @tcrowe who is putting the finishing touches on the issue, Deploy to ipfs. This way your changes can be ensured to fall into his deployment or used as a test for the new CI configuration with ipfs.

Sent from ProtonMail mobile

-------- Original Message -------- On 14 Feb 2020, 15:59, Mulili Nzuki wrote:

An update, just testing my changes and then I submit the PR.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

tcrowe commented 4 years ago

https://t.me/OpenDeFi https://t.me/tcrowe

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Cancelled

The funding of 450.0 DAI (450.0 USD @ $1.0/DAI) attached to this issue has been cancelled by the bounty submitter

Questions? Checkout Gitcoin Help or the Gitcoin Slack
$112,575.85 more funded OSS Work available on the Gitcoin Issue Explorer

MyBitFoundation / MyBit-Go.app

Change Asset Collateral Structure #517