search

MyBitFoundation / MyBit-Go.app

🔷 The MyBit Platform™ for investing in alternative assets
https://app.mybit.io
GNU General Public License v3.0
8 stars 31 forks source link

Update from SAI to DAI #522

Closed cryptnotiq closed 4 years ago

cryptnotiq commented 4 years ago

On both funding of assets and distributing revenue, the Go platform needs to be updated from using SAI to DAI.

Here is an example of a failing transaction when an asset manager is attempting to pay out dividends https://etherscan.io/tx/0x89df6debb1c6b8eb7818f9400bffda48412ece18425f815fd010d333d25a2b5b

Once completed, the update must also be published to production by you, which may require you to do so manually on our server because our automated tools have been failing when changes are merged into the master branch.

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 100.0 DAI (100.0 USD @ $1.0/DAI) attached to it.

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 1 month from now. Please review their action plans below:

1) igormuba has started work.

Update the contract from SAI to DAI

Learn more on the Gitcoin Issue Details page.

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 100.0 DAI (100.0 USD @ $1.0/DAI) has been submitted by:

  1. @igormuba

@cryptnotiq please take a look at the submitted work:

cryptnotiq commented 4 years ago

@igormuba tests still failing when I try to merge develop with master. https://github.com/MyBitFoundation/MyBit-Go.app/pull/525

igormuba commented 4 years ago

@cryptnotiq I saw that, I am still thinking what could it be. It is weird because I only changes the address of the contract on the first commit, so if it was working before it should have worked that time.

The first failing message I saw was something about docker, but I did not touch the docker par. I tried to look at other merges that worked, and the other ones, done by @csmartinsfct do not do those tests. Actually it is super weird, because only him can merge, and other merge requests fail.

I thought that maybe undoing the commit done by @jjperezaguinaga would do something, by removing the dockerisation, because after this pull, apparently, is when the issues with docker started. But seems like that is either not the case, or not the only reason.

I still can't understand how just changing the contract address would make it stop working, if both tokens are ERC20.... I am thinking about what can I do now. Maybe I will undo the changes that removed dockerisation, maybe that would work on master, if it was working for csmartinsfct so far, not sure.

igormuba commented 4 years ago

I have found what the issue was. Now.sh does not support docker anymore https://spectrum.chat/zeit/general/how-would-i-deploy-this-docker-based-solution-with-now-v2~cf5caeca-31fd-4bd9-81a8-a68a6ce1e54a

I am now reading about what are the options.

igormuba commented 4 years ago

@cryptnotiq I did a new pull request, but apparently they have reached the limit of usage for the free tier of now.sh v1.0 and the v2.0 does not support docker

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 100.0 DAI (100.0 USD @ $1.0/DAI) has been submitted by:

  1. @igormuba
  2. @igormuba

@cryptnotiq please take a look at the submitted work:

cryptnotiq commented 4 years ago

@igormuba what is your telegram ID? I want to message you there about finalising this and getting it into production.

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 100.0 DAI (100.0 USD @ $1.0/DAI) has been submitted by:

  1. @igormuba
  2. @igormuba

@cryptnotiq please take a look at the submitted work:

igormuba commented 4 years ago

@cryptnotiq my telegram ID is @IgorM12Sc312 message me there as soon as you can and I will change it after this, for privacy reasons, to not let my ID floating around on github (too many spammers)

cryptnotiq commented 4 years ago

hey @igormuba just tried to message you and it says the user does not exist.

igormuba commented 4 years ago

@cryptnotiq try again, also, give me your telegram ID so I can try here, to make sure one of us manages to contact the other

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Cancelled

The funding of 100.0 DAI (100.0 USD @ $1.0/DAI) attached to this issue has been cancelled by the bounty submitter