search

MyBitFoundation / MyBit-Go.app

🔷 The MyBit Platform™ for investing in alternative assets
https://app.mybit.io
GNU General Public License v3.0
8 stars 31 forks source link

fix docker error #524

Closed aniebietudoh closed 4 years ago

aniebietudoh commented 4 years ago

This PR fixes Docker error which causes build to always fail.

cryptnotiq commented 4 years ago

can you re-open this PR and recreate the branch you deleted? I can't merge the pull request bc of that. @revealtheweb

aniebietudoh commented 4 years ago

@cryptnotiq The PR doesn't fix the issue that's why I closed it. The problem lies in the fact that Now.sh no longer supports docker deployments which is used to deploy the app, so simply removing the "--docker" flag does not solve the issue. From my research, the project has to be migrated to a current Now.sh deployment method. I also noticed that builds started failing on 11 Dec 2019, right after the time the support for docker was stopped.

cryptnotiq commented 4 years ago

@revealtheweb excuse my ignorance but is that migration easy to do or will it take extensive time?

aniebietudoh commented 4 years ago

@cryptnotiq for an existing system like this, migration will take a fairly valuable amount of time. As a possible but risky alternative, you could set up travis and circle CI to still deploy without passing all checks, but that would open up the system to potential bugs. So I highly discourage that. The best option is to migrate as directed by Now.sh

cryptnotiq commented 4 years ago

ok thanks for your research @revealtheweb

cryptnotiq commented 4 years ago

@revealtheweb can you please share your telegram ID so we can discuss manual deployment there?

aniebietudoh commented 4 years ago

@cryptnotiq Telegram is: @revealtheweb