search

MyBitFoundation / MyBit-Go.app

🔷 The MyBit Platform™ for investing in alternative assets
https://app.mybit.io
GNU General Public License v3.0
9 stars 31 forks source link

Bring to Production #545

Closed cryptnotiq closed 4 years ago

cryptnotiq commented 4 years ago

Updated Issue

The following is a comprehensive list of tasks to be completed for v2.0 of MyBit.

Useful Resources (code is well documented) Application Front End: https://github.com/MyBitFoundation/MyBit-Go.app Smart Contracts: https://github.com/MyBitFoundation/MyBit-Network.tech Smart Contract Documentation: https://developer.mybit.io/network/ Updating Contracts Guide: https://github.com/MyBitFoundation/MyBit-Network.tech/blob/c1f458aa8a/UpdateProcess.md MyBit.io Landing Website: https://github.com/MyBitFoundation/MyBit-Go.website

Additional Resources MyBit DAO: https://mainnet.aragon.org/#/0xcD3d9b832BfF15E0a519610372c6AAC651872DdE/ UI Kit: https://ui.mybit.io/ Hello World App: https://developer.mybit.io/hello-network/ Brief MyBit Chain Documentation: https://developer.mybit.io/chain/ Network.js Documentation: https://developer.mybit.io/web/ Website: Mybit.io Application: app.mybit.io Ropsten TestNet Application (latest version): https://my-bit-go-app.vercel.app/explore

Core Functionality Tasks to complete. Many will involve updating both the Application FrontEnd and the Smart Contracts.

  1. 3rd party dependencies should be removed so anyone can fork the repository and deploy on their own (via Zeit Now or a similar solution).

    The Current Dependencies that require API Keys are: a. Infura can be generated on its website by anyone. b. civic needs to be removed c. Airtable can be copied d. AWS & S3 bucket - we need a replacement to this. Any service that can host static images in an open way where others can also use or easily copy like airtable. Or NextJS. e. Google places API needs to be removed.

  2. Update from SAI to DAI - On both funding of assets and distributing revenue, the Go platform needs to be updated from using SAI to DAI. The Kyber integration must also be updated for this.

  3. Remove Civic from List Asset Process including:

    a. Remove it during the listing asset process (displays QR code) that must be scanned and approved in Civic mobile app to proceed to next stage of listing an asset. b. Also remove any mention of CIvic from the first page of list an asset process and change the button from Civic - to Get Started. c. Remove the section on individual assets which says (identity proved by civic) and then lists email, phone, etc. verified. https://app.mybit.io/asset/ 0x151Af273821836c670e4F7E3642b0182DC5fE54a d. Remove any other sections that include Civic. Such as in the tutorial pop-ups or anywhere else.

  4. Change List Asset Process

    The current process to list an asset for funding is very complicated and involves the MyBit DAO. Our goal is to vastly simplify this and remove all restrictions so anyone can list any asset they choose and provide all the details themselves instead of being restricted to a pre-defined list. This will also remove location restrictions because under the current process, approved assets may only be offered in specific locations, we want this to stop and have any asset available anywhere.

    The Current Process: a. On the MyBit DAO an Operator opens a vote for an asset. Via this module: https://github.com/ MyBitFoundation/MyBit-DAO.tech/tree/master/apps/MyBit-Operators b. If the Vote is approved then the Operator can add the asset to the Mybit Platfform with all the details including price, locations available, pictures, etc. c. The asset is then made available via the dropdown list for people to list (if available in their location).

    The New Process a. No pre-approval required and no pre-defined list of assets. Anyone can list any asset they want. b. User is responsible for uploading all details including prices, pictures, and other information. The Main functionality changes here are how the data and files are stored and how the unique asset is created. c. In the UI a screen to upload a cover picture is required (limit to 1 picture for an asset) d. The Asset Price will become Dynamic and the user will have to input the value.

  5. Update Asset Collateral Structure

    This is the last step of Listing an Asset. A deposit in MYB is currently required to be used as a type of insurance/protective bond for investors. As revenue is paid out the user who listed the asset can receive the MYB back in increments of 25%. When 25% of revenue is paid, 25% of MYB can be withdrawn. I.e if an asset cost $1,000, when $250 worth of revenue is paid out, the user can withdraw 25% of their MYB that was used as collateral. You can visual this on the Front End on the Portfolio - Manage Asset Page. The Asset Collateral (Deposit in MYB) is currently a fixed value, you can read more about how it is calculated under the asset managers tab here https://app.mybit.io/help

The new Asset Collateral Structure should change to a Dynamic Value that the user has full control over. The user can enter a Percentage from 0% to Unlimited and then that value is calculated. i.e if asset value was $1000 and user put in 10%, $100 worth of MYB would be required to list the asset. This value is then passed to Kyber (directly integrated into the page) so a user can pay with any cryptocurrency in their metamask account supported by Kyber and it will automatically convert to the appropriate amount of MYB.

Notes: On the smart contract side of things it should just require a call to setCollateralLevels() on the Platform contract.

The withdrawal process at 25% intervals will remain the same.

This will also need to be updated on the Asset Details page, so it is clear to investors, how much the User who listed the asset put down as collateral. It can be listed as a percentage.

  1. Update Fees and Payable ETH Addresses

Current Fees are explained in the Fees section on the help page https://app.mybit.io/help

This can be fully removed: MyBit Go keeps 1% of ownership of listed assets, or in the case of community driven operators, this ownership is provided to the community member that onboarded the operator.

The Remaining fees will be changed and simplified to one address. Charge a Flat Rate of 5 DAI when each asset is Listed Charge 5% of Asset Listing Value (once successfully funded) Take 5% of all revenue distributions (every time they are paid out)

All payments can go to: (MYB 2 Address)

Note: The community will choose how to allocate collected fees between development, marketing, burning MYB, etc. Currently these fees will go to a centralised eth address. Over time we will create a community DAO like Kyber where decisions can be managed and executed on chain, in a truly decentralised manner.

FrontEnd-UI/Design Tasks: These will involve updates to MyBit.io and the Mybit Application. All should be very simple, we are not making any overhauls to the overall design system or layout structure, just fine-tuning what we already have.

  1. Update Font across all App and MyBit Site to https://fonts.google.com/specimen/Assistant?query=assi

  2. Remove MyHedge in NavBar Menu

  3. Remove Categories from Explore Assets Page and just have Filter/Sort Option.

  4. Update Color of NavBar and Site Sections to R: 82 G: 134 B: 237

  5. Use all white mybit logo from mybit.io on app header

  6. Update all mentions of “MyBit Go” to just “MyBit”. Across Site and in tab panel (next to favicon)

  7. Simplify and Redesign Footer (use same on MyBit.io and Application).

    There will only be 2 Columns now. 1st Column: Row 1: MyBit Logo Row 2: MyBit is a Community Driven Project Row 3: that is operated and maintained by a DAO. Row 4-5:  https://mainnet.aragon.org/#/ 0xcD3d9b832BfF15E0a519610372c6AAC651872DdE/

    2nd Column: Title: Contribute Row 1: Github (link to: https://github.com/MyBitFoundation) Row 2: Smart Contract Documentation (https://developer.mybit.io/network/) Row 3: APIs (https://developer.mybit.io/network/docgen/docs) Row 4: UI Kit (Link to: https://ui.mybit.io/) Row 5: Chat (link to: https://t.me/mybitio)

    Remove Copyright and replace with social icons: Telegram, Reddit, Twitter

  8. Update Onboarding Pop-Ups: Screen 1: Update text and Logo from MyBit Go to just MyBit. Screen 2: MyBit Go to MyBit Screen 3: MyBit Go to MyBit Everything else is good.

  9. Update Content on List Asset, Require Certain Fields (have standard red star, do not let proceed until all required are filled in), and Create Accepted Values, i.e only numerical for value inputs.

    a. Screen 2: MyBit Go to Mybit b. Step 1: Change Title to “Select Asset”, remove question mark icon, remove sentence “different assets……you are”, City (only accept alphabetical characters), Change Selected Asset Value to “Asset Value”, and only accept numerical values (whole numbers, no decimals). c. Step 4: Remove this. Also update on Front End asset details page. Just having City and Country from Step 1 is enough. d. Step 7: Change Your Escrow to Choose Escrow Amount and have input field. Remove ? icon. Remove second sentence (it is calculated…… asset manager…), keep Learn More.

Original Issue

There are many small to medium sized tasks that need to be completed to bring this app to production.

First, It needs to be easy to fork, test, and deploy via Zeit.

  1. 3rd Party Dependencies need to be removed - Zeit will ask for many API secrets when deploying the app. a. Infura can be generated on its website by anyone. b. civic needs to be removed c. Airtable can be copied d. AWS & S3 bucket - we need a replacement to this. Any service that can host static images in an open way where others can also use or easily copy like airtable. e. Google places API needs to be removed.

Once you successfully deploy via zeit, please share the Zeit app URL for review.

Second, Configure Docker so the whole network can be run locally and everything can be easily tested.

Third - make some small changes to the dapp.

  1. Update Footer to display UI-Footer Package - which should follow this layout structure https://github.com/MyBitFoundation/MyBit-Go.app/issues/512
  2. Remove Civic - which includes https://github.com/MyBitFoundation/MyBit-Go.app/issues/515
  3. Update from SAI to DAI - On both funding of assets and distributing revenue, the Go platform needs to be updated from using SAI to DAI. The Kyber integration must also be updated for this.

Fourth, Change a feature Change Asset Collateral Structure - following this model I originally proposed https://github.com/MyBitFoundation/MyBit-Go.app/issues/517

Fifth, Completely change how assets are added. Currently assets are only added when approved via the DAO. Instead, we want to make it so anyone can upload their own asset. Some small UX changes may need to be made such as ability to upload an image instead of pulling an existing image from our database. i.e We totally change it and let anyone list anything and provide all the details and then it is saved in the database just for that listing and isn't re-used. So if someone wants to list a new asset they can just go ahead and do it without having to have it approved first.

Last, Charge flat rate of 5 DAI for listing an asset. ETH Address to receive fee TBD.

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 4200.0 DAI (4200.0 USD @ $1.0/DAI) attached to it.

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 3 weeks, 6 days from now. Please review their action plans below:

1) pbteja1998 has been approved to start work.

I have worked with MyBit before. I am the one who created a website to show MyBit white paper(https://whitepaper.mybit.io/). I am also the one who setup MyBit's UI Toolkit repo(https://github.com/MyBitFoundation/MyBit-UI-Toolkit.app)

I want to work on the set of issues that are listed out in this bounty. Everything seems straightforward except 1 or 2 issues. I will try to complete all these in a week. And I will give constant updates to keep the team in sync with what I have been doing.

Learn more on the Gitcoin Issue Details page.

cryptnotiq commented 4 years ago

@pbteja1998 - could you please join telegram https://t.me/mybitio to discuss the bounty and what the 1 to 2 issues that are not straightforward are?

gitcoinbot commented 4 years ago

@pbteja1998 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

pbteja1998 commented 4 years ago

@cryptnotiq will join the telegram chat and I will ask further questions from there.

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of this issue was increased to 4210.0 DAI (4210.0 USD @ $1.0/DAI) .

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of this issue was increased to 4510.0 DAI (4510.0 USD @ $1.0/DAI) .

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of this issue was increased to 4910.0 DAI (4910.0 USD @ $1.0/DAI) .

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of this issue was increased to 4990.0 DAI (4990.0 USD @ $1.0/DAI) .

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of this issue was increased to 5000.0 DAI (5000.0 USD @ $1.0/DAI) .

gitcoinbot commented 4 years ago

@pbteja1998 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

pbteja1998 commented 4 years ago

@gitcoinbot still working

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of this issue was increased to 5250.0 DAI (5250.0 USD @ $1.0/DAI) .

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of this issue was increased to 5300.0 DAI (5300.0 USD @ $1.0/DAI) .

gitcoinbot commented 4 years ago

@pbteja1998 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

pbteja1998 commented 4 years ago

@gitcoinbot still working on it.

gitcoinbot commented 4 years ago

@pbteja1998 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

@pbteja1998 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

pbteja1998 commented 4 years ago

@gitcoinbot yes. Still working on it. Will open a WIP PR soon.

gitcoinbot commented 4 years ago

@pbteja1998 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

@pbteja1998 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@pbteja1998 due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

pbteja1998 commented 4 years ago

@gitcoinbot posted the update in the telegram chat of the project.

gitcoinbot commented 4 years ago

@pbteja1998 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

@pbteja1998 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@pbteja1998 due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@pbteja1998 due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

@pbteja1998 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

@pbteja1998 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Cancelled

The funding of 5300.0 DAI (5300.0 USD @ $1.0/DAI) attached to this issue has been cancelled by the bounty submitter

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 9000.0 DAI (9000.0 USD @ $1.0/DAI) attached to it.

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Cancelled

Work has been started.

These users each claimed they can complete the work by 265 years, 5 months from now. Please review their action plans below:

1) iamonuwa has been approved to start work.

Already completed the hard part of this issue. Discussing with the team to complete the rest. ETA, end of today.

Learn more on the Gitcoin Issue Details page.

gitcoinbot commented 4 years ago

@iamonuwa Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

iamonuwa commented 4 years ago

@gitcoinbot work in progress. PR soon. App is deployed to https://my-bit-go-app.vercel.app/explore

gitcoinbot commented 4 years ago

@iamonuwa Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@iamonuwa due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Cancelled

The funding of 9000.0 DAI (9000.0 USD @ $1.0/DAI) attached to this issue has been cancelled by the bounty submitter