MyBitFoundation / MyBit-UI-Toolkit.app

πŸ”· MyBit Ecosystem UI
https://ui.mybit.io
GNU General Public License v3.0
1 stars 16 forks source link

Mono-repo/multi-repo Setup? #20

Open fetchTe opened 6 years ago

fetchTe commented 6 years ago

Correct me if I'm incorrect, but this repo is essentially your component library. As such I highly recommend you migrate away from "create-react-app" (react-scripts) in favor of a mono-repo and/or multi-repo setup that leverages lerna. There's a whole slew of reason why this setup is highly advantageous for component libraries from extensibility to compatibility plus at this stage of the game the transition would be relatively painless. I bring this to your attention because I've already hit a few road-blocks developing the new #18 component due to react-scripts. I'm quite familiar with the creation of mono-repos and the various integrations needed to wrangle everything together. So if you interested I'm more than willing to handle and/or aid this transition.

0xjjpa commented 6 years ago

Hi @artisin , let me address your comments ☺️

Correct me if I'm incorrect, but this repo is essentially your component library.

Yes, that's correct! You can preview the latest version on https://5379114-ui-mybit-io-dev.now.sh/.

As such I highly recommend you migrate away from "create-react-app" (react-scripts) in favor of a mono-repo and/or multi-repo setup that leverages lerna. There's a whole slew of reason why this setup is highly advantageous for component libraries from extensibility to compatibility plus at this stage of the game the transition would be relatively painless.

Indeed, we are looking for a mono-repo setup, mainly since we want to have only one repository in Github, yet the ability to publish and/or fetch only one. However, we are not using react-scripts for publishing the components but neutrino. The issue is that our "gallery" is built with CRA. We had been thinking in moving the gallery to other project and just split this into two modules managed by lerna. How that sounds?

I bring this to your attention because I've already hit a few road-blocks developing the new #18 component due to react-scripts.

Thanks and sorry! We are still building our stack, so we are still hitting a couple bumps on the road 😒

I'm quite familiar with the creation of mono-repos and the various integrations needed to wrangle everything together. So if you interested I'm more than willing to handle and/or aid this transition.

Sounds good! If you can wrap #18 then we can propose an issue we can then add a bounty on, how that sounds?

0xjjpa commented 5 years ago

@artisin πŸ‘‹ are you still interested in working in this?

fetchTe commented 5 years ago

Heya @jjperezaguinaga - I actually sent you a email a while back detailing all kinds of issues/thoughts. Furthermore, this task has already been completed but since I never heard back from you I moved on unfortunately. Maybe we crossed wires somewhere along the line but I missed your response or my email erroneously misclassified your response. I rather not talk about my current position publicly but I'd be happy to pick this conversation back up privately. Just shoot me an email at ey@teschultz.com and we can exchange details.

0xjjpa commented 5 years ago

@artisin No worries! I've sent you an invite to our Basecamp where you can ping me directly with any details you want to describe further. Thanks!