Assigning E-units in future - not working

[mnichols13]

When a teacher assigns E-units to a future date, the student should not be able to view and open these E-units until that date hits. Currently this is not the case, students are able to see these E-units even though the teacher has them assigned for a future date. We had this issue in October, I thought it was fixed, but apparently it is not. The calendar does show the correct information, but under the Assigned E-units section they all show up.

[BrianPeterlin]

Mindy

How are they being assigned? From the Course Outline view or from the Assign eUnits View

Are they being assigned to an individual student or students in a course?

[mnichols13]

The ones that I assigned were from the Assign E-units view to all students in a course outline.
Ag Mechanics Fall 2013 assigned nine e-units with various dates from today through the 13th all are currently available for the students to view

[bguerrettaz]

Ok, I think I might have a fix in for this, but I'll ask that you test some around this before we are confirmed.

It was a pretty complicated fix and I want to make sure its functioning as desired.

Please let me know your findings.

[mnichols13]

on my IL account username/password: all/123 I assigned four ppts in the Horticulture for Beginners Course. I have one student: Lucy Nichols I assigned the following dates: 2/7, 2/10, 2/11,2/12 When I sign in as Lucy I can see all four instead of just the one available for today. So I guess my test indicates that it is NOT FIXED.

[bguerrettaz]

Sorry I should've been more specific, this fix is just for eUnits. If this works as desired, I will put the fix in for PPTs as well.

Sorry for the confusion.

Sent from my iPhone

On Feb 7, 2014, at 1:18 PM, mnichols13 notifications@github.com wrote:

on my IL account username/password: all/123 I assigned four ppts in the Horticulture for Beginners Course. I have one student: Lucy Nichols I assigned the following dates: 2/7, 2/10, 2/11,2/12 When I sign in as Lucy I can see all four instead of just the one available for today. So I guess my test indicates that it is NOT FIXED.

— Reply to this email directly or view it on GitHub.

[mnichols13]

Actually I did assign E-units, not sure why I said ppts.. my mistake...

[bguerrettaz]

So I looked more into what is causing this issue. Here is what I found:

This actually works correctly after my fix for individually assigned E-Units. The problem is actually related to the QuizClass. Whoever built the original process did not put an activate or deactivate date on the table that holds the data for e-units assigned to the entire quiz class. The e-units that are individually assigned do include the activate and deactivate dates.

I'm not sure if this was by design or not.

Here are two screenshots of the tables and their differences:

Individual E-Units data table:

QuizClass data table:

To resolve this, I'll have to create those two missing columns on the quiz class table, then update the code within the quiz class update dates page.

Please let me know if we're good to proceed or if you have questions.

Blake

[dpentony]

Please proceed

[bguerrettaz]

Ok, I think I have everything in place that needs to be for both individual students and the quiz class.

Please test both of these. I also accounted for dates that have not been set by the teachers.

Brian and I spoke about this both last night and this morning to make sure we were on the same page.

Please test both students and quizclasses for E-Units and let me know your findings.

If this works as desired, I can make the same changes for PPT's.

Blake

[mnichols13]

Same example: on my IL account username/password: all/123 I assigned four ppts in the Horticulture for Beginners Course. I have one student: Lucy Nichols I assigned the following dates: 2/7, 2/10, 2/11,2/12 When I sign in as Lucy I can see all four instead of just the two that have current dates. (2/7 and 2/10) I am sorry it doesn't look any different on the teacher side..

[BrianPeterlin]

Mindy, did you assign PPT or eUnits in your test?

[mnichols13]

e-units

[bguerrettaz]

Sorry, this one is on me. I saved the code I updated, but to a different file. I'm made the correction, please retest.

Thanks, Blake

[mnichols13]

Looks good now! I tested both assigning E-units to a course and an individual student. Both looked to work correctly.

[dpentony]

I think this fix has caused another issue. I've had two teachers contact us saying that the Eunits they have assigned for courses are not showing up for their students. One is Derek Straube in the national state. He has two courses (Ag Tech II and Natural Resources) where his assigned Eunits are not showing up for the kids. When I look at Maintain Assigned Eunits, he has them some assigned and active but they kids can't see them. Please advise ASAP. I am guessing it has to do with the whole course/quiz class concept.

[bguerrettaz]

I will look at this ASAP..

Sent from my iPhone

On Feb 11, 2014, at 11:06 AM, dpentony notifications@github.com wrote:

I think this fix has caused another issue. I've had two teachers contact us saying that the Eunits they have assigned for courses are not showing up for their students. One is Derek Straube in the national state. He has two courses (Ag Tech II and Natural Resources) where his assigned Eunits are not showing up for the kids. When I look at Maintain Assigned Eunits, he has them some assigned and active but they kids can't see them. Please advise ASAP. I am guessing it has to do with the whole course/quiz class concept.

— Reply to this email directly or view it on GitHub.

[BrianPeterlin]

blake, call my cell if you want to discuss

1-309-310-4551

[dpentony]

The other teacher was Mike Thofson in MN. He had a problem last night for his Animal Science Horses/Sheep/Goats course. When I looked at it, he had 9 Eunits assigned and active but the kids could not see them. I went in, set them all to inactive and the re-activated them. After doing that, the kids could see them. I tried that with one of Derek Staube's courses, but it did not work.

[bguerrettaz]

Last night I was able to identify the data issue that caused some teachers to report their students not being able to see assigned eUnits.

I have just finished coding and testing the additional code.

To eliminate teachers having any other issues real-time, I have created an additional page for us to test and fully vet.

When logging in as a student and clicking on view assigned e-units you'll come to the following page:

http://www.mycaert.com/Students/ViewAssignedEUnitsNew.asp

replace this URL with

http://www.mycaert.com/Students/ViewAssignedEUnitsNew_Blake.asp

You'll have to make sure _Blake is at the end of the name of the page to make sure you are seeing the current solution.

The bad data was the data 01/01/1900 set as default, I have accounted for this now.

Please test this and let me know when you want this placed into production.

Again, once we've fully tested this, PPT's is next.

Blake

[BrianPeterlin]

great?

can you take a look at the assign eunit code?

i believe that is the source of the 01/01/1900 entries

it appears that process is not assigning dates correctly for quiz classes

Brian Peterlin Cell# 1-309-310-4551

On Feb 12, 2014, at 6:10 PM, bguerrettaz notifications@github.com wrote:

Last night I was able to identify the data issue that caused some teachers to report their students not being able to see assigned eUnits.

I have just finished coding and testing the additional code.

To eliminate teachers having any other issues real-time, I have created an additional page for us to test and fully vet.

When logging in as a student and clicking on view assigned e-units you'll come to the following page:

http://www.mycaert.com/Students/ViewAssignedEUnitsNew.asp

replace this URL with

http://www.mycaert.com/Students/ViewAssignedEUnitsNew_Blake.asp

You'll have to make sure _Blake is at the end of the name of the page to make sure you are seeing the current solution.

The bad data was the data 01/01/1900 set as default, I have accounted for this now.

Please test this and let me know when you want this placed into production.

Again, once we've fully tested this, PPT's is next.

Blake

Reply to this email directly or view it on GitHubhttps://github.com/MyCaert/Issues-Enhancements/issues/23#issuecomment-34934433 .

[bguerrettaz]

I found that as well, here is the code that is responsible for filling in invalid dates:

      Assign Date: 
      <% If tempAssignDate = "1/1/1900" then
            tempAssignDate = ""
        End if

        If tempDueDate = "1/1/1900" then
            tempDueDate = ""
        End if

[bguerrettaz]

I'll clean it up too.

[bguerrettaz]

Actually after reading this and the code around it, it looks like this is taking dates that WERE set like this and properly setting it to "" (blank or NULL). That is what we want.

I cannot find where they are being set to this, I'll keep looking.

[BrianPeterlin]

call me, i think i know

Brian Peterlin Cell# 1-309-310-4551

On Feb 12, 2014, at 6:49 PM, bguerrettaz notifications@github.com wrote:

Actually after reading this and the code around it, it looks like this is taking dates that WERE set like this and properly setting it to "" (blank or NULL). That is what we want.

I cannot find where they are being set to this, I'll keep looking.

Reply to this email directly or view it on GitHubhttps://github.com/MyCaert/Issues-Enhancements/issues/23#issuecomment-34936974 .

[BrianPeterlin]

1) http://www.mycaert.com/Teachers/students/assign-eunits-v2.asp?opt=ddl

2) see attached

3) Possibly this page, but more than likely it is ok http://www.mycaert.com/Teachers/students/select-eunits-course-outline.asp?QuizClassID2=28439&Scope=QuizClass&OutlineID=21796

4) Possibly this page is putting them in, but more than likely it is ok http://www.mycaert.com/Teachers/students/edit-dates.asp?AssignBy=QuizClass&StudentID=&QuizClassID=27918&ID=156382#156382

you get to this page by going to Maintain eUnits under My Students

I am guessing some of these pages are putting in the 1900 date when assigning to a quiz class

[BrianPeterlin]

I checked the 4 pages and they all look good.

I believe ViewAssignedEUnitsNew_Blake.asp is working. @dpentony and @mnichols13, please review and give your go ahead to move into production

[mnichols13]

Using the provided URL: http://www.mycaert.com/Students/ViewAssignedEUnitsNew_Blake.asp

This works now.

[bguerrettaz]

Are you all ready to move this into production?

[dpentony]

Based on Mindy's review, it appears you are OK to proceed.

[bguerrettaz]

Sounds good, I will get this in and make the same changes for PPT's.

Blake

[bguerrettaz]

The eUnits page is now live. The PPT page is a little different and is taking a bit longer than expected. Should be done sometime tomorrow.

[bguerrettaz]

Ok, I now have the PPT page completed.

I have also created a test page for you to validate the changes.

Same applies as it did for eUnits, please add the _Blake to the end of the URL, before '.asp'

http://www.mycaert.com/Students/ViewAssignedPPTsNew_Blake.asp

Once you have vetted the changes, I will make this live and I think we'll be able to close this issue.

Blake

[bguerrettaz]

Were you able to verify this today?

[dpentony]

Mindy, please let us know if this works OK for PPTs

[mnichols13]

The fix is working well with PPTs too. I will close the issue.