MyCaert / Issues-Enhancements

Issues and Enhancements
2 stars 0 forks source link

Teachers have access to quiz questions for libraries they don't subscribe #348

Closed mnichols13 closed 2 years ago

mnichols13 commented 2 years ago

I've noticed for the Illinois teachers - who no longer get a state subscription - still have access to all of the quiz questions even when they don't pay for a lesson library.

Example: Josh Bullard in IL
username: Bullard pw: Foxrace44

He only pays for Middle School - however he is able to create quizzes from any of his old course outlines. He should only be able to access the quiz questions from Middle School.

Please fix.

bguerrettaz commented 2 years ago

I'm looking into this, I'll update on findings.

On Tue, Jan 4, 2022 at 8:14 AM mnichols13 @.***> wrote:

I've noticed for the Illinois teachers - who no longer get a state subscription - still have access to all of the quiz questions even when they don't pay for a lesson library.

Example: Josh Bullard in IL username: Bullard pw: Foxrace44

He only pays for Middle School - however he is able to create quizzes from any of his old course outlines. He should only be able to access the quiz questions from Middle School.

Please fix.

— Reply to this email directly, view it on GitHub https://github.com/MyCaert/Issues-Enhancements/issues/348, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLOP45KARVNQCJCYX32MVTUUL6ETANCNFSM5LHRNBPQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

bguerrettaz commented 2 years ago

Hi - I'm not seeing where he has this access, could you give me your steps so I can emulate?

Thanks, Blake

On Thu, Jan 6, 2022 at 4:10 PM Blake Guerrettaz @.***> wrote:

I'm looking into this, I'll update on findings.

On Tue, Jan 4, 2022 at 8:14 AM mnichols13 @.***> wrote:

I've noticed for the Illinois teachers - who no longer get a state subscription - still have access to all of the quiz questions even when they don't pay for a lesson library.

Example: Josh Bullard in IL username: Bullard pw: Foxrace44

He only pays for Middle School - however he is able to create quizzes from any of his old course outlines. He should only be able to access the quiz questions from Middle School.

Please fix.

— Reply to this email directly, view it on GitHub https://github.com/MyCaert/Issues-Enhancements/issues/348, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLOP45KARVNQCJCYX32MVTUUL6ETANCNFSM5LHRNBPQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

mnichols13 commented 2 years ago

When logged in as Josh, go to create a quiz, choose add questions by course outline and choose any of the questions from old created course outlines. For example Ag Mechanics or Ag Business, neither of which he pays for.

Also you can go to Edit Quiz. Choose Ag Mechanics as the course outline, then click edit questions. All of the quiz questions are visible.

bguerrettaz commented 2 years ago

Ok, I've looked into this quite a bit and unfortunately, quizzes currently have no logic to see if the existing quizzes course outlines are still available. This is true both for add and edit.

So in this case, I don't see any new course outlines built from the new lesson plan library that this user subscribes to, is that correct?

So all of that logic will need to be built into both add and edit quiz and I would suggest some testing to make sure we don't break other users.

Please let me know what you think.

Blake

On Fri, Jan 7, 2022 at 3:11 PM mnichols13 @.***> wrote:

When logged in as Josh, go to create a quiz, choose add questions by course outline and choose any of the questions from old created course outlines. For example Ag Mechanics or Ag Business, neither of which he pays for.

Also you can go to Edit Quiz. Choose Ag Mechanics as the course outline, then click edit questions. All of the quiz questions are visible.

— Reply to this email directly, view it on GitHub https://github.com/MyCaert/Issues-Enhancements/issues/348#issuecomment-1007743644, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLOP46DA5HZPM2FMBRKKDLUU5JIPANCNFSM5LHRNBPQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

mnichols13 commented 2 years ago

Blake, At this point, I think we leave it as is. It does affect that many users. Thank you for looking into this.