MyCaert / Issues-Enhancements

Issues and Enhancements
2 stars 0 forks source link

Assigning individual ppts/E-units from course outline page does not work #89

Closed mnichols13 closed 9 years ago

mnichols13 commented 9 years ago

We had a teacher trying to assigning ppts to an individual student through the Course Outline page. After choosing the student, the ppt or e-unit and submitting the page the teacher should get a confirmation this is complete or successful - Instead the teacher gets the Maintain assigned e-units/ppts page.

Please add this to the top of the priority list along with fixing the calendar dates associated with assigning materials.

bguerrettaz commented 9 years ago

I actually just tried to recreate this with Dan's account with student Bob Johnson, course Ag Mechnics and wasn't able to. Can you please try to recreate and walk me through the steps?

mnichols13 commented 9 years ago
  1. open course outline from MY COURSES link
  2. click icon in center of page: assign ppts
  3. click assign ppts to select students
  4. click course name again
  5. click student name - add to assign students box
  6. choose ppts
  7. select default status: active
  8. click to assign ppts Once I click to assign ppts I am taken to the maintain ppts page - instead of a success message.
bguerrettaz commented 9 years ago

Ok, I found the code responsible, it does look like it was designed this way:

if tempScope = "QuizClass" then Response.Redirect("/Teachers/Students/maintain-assigned-ppts.asp?AssignBy=QuizClass&QuizClassID=" & tempQuizClassID)
else Response.Redirect("/Teachers/Students/maintain-assigned-ppts.asp") end if

Do you want this to change to the thank you page for both PPT's and E-Units? Do you want to leave it as designed?

dpentony commented 9 years ago

I recall we had discussion about how the Assign Eunits/PPTs link in the center of the page is designed. I think the problem is that is operates differently from the Assign link next to each lesson and the Assign link under MY Students.

What would it take to make the Assign link in the center of the page operate the same way as the Assign link next to each lesson when you choose Assign Multiple PPTs/Eunits? If those two links could operate the same way, it would alleviate confusion.

bguerrettaz commented 9 years ago

So in essence, once they assign EUnits/PPTs, you would like them to be redirected to the thank you page, rather than where they are going now?

dpentony commented 9 years ago

Yes, once they SUCCESSFULLY assign them they should get a thank you page.

bguerrettaz commented 9 years ago

The changes to Assign PPT's and Assign EUnits pages are now complete.

Please test and confirm.

Hours: 3.25

mnichols13 commented 9 years ago

I think it looks good, however one issue that I had once again is with previous dates. If there happens to be a old date that the materials were assigned and as a teacher I don't take the time to look for it, then the students will not be able to see these materials. Yet when I assign them a 2nd time, it gives me the You are successful message.

Would it be possible for an error message or a flag of some sort to pop up to let the teacher know that they need to update their assign dates?

bguerrettaz commented 9 years ago

Would something like if the assign AND due dates are anytime before today, a warning message pops up and says something like, one of more of your PPT/EUnit assignments is out of date?

This new code would have to go anywhere that assignments are possible (Assign page, Course Outline page on the individual links and the links in the center of the page).

Would something like that work?

mnichols13 commented 9 years ago

Yes I think so... can you give us a time estimate on that?

bguerrettaz commented 9 years ago

Hours for everything 6-8 hours.

On Mon, Sep 29, 2014 at 2:28 PM, mnichols13 notifications@github.com wrote:

Yes I think so... can you give us a time estimate on that?

— Reply to this email directly or view it on GitHub https://github.com/MyCaert/Issues-Enhancements/issues/89#issuecomment-57214843 .

dpentony commented 9 years ago

OK to proceed based on 6 to 8 hours estimate.

bguerrettaz commented 9 years ago

Ok, I have a working version of the alert on the maintain e-unit page. (http://mycaert.com/Teachers/students/default.asp)

Once you click the calendar icon, the code to checks whether any of the assign/due dates are before today, if so, you get an alert.

Please test this and confirm its working as desired. If so, I'll make this change in the other places you'd like.

Thanks, Blake

mnichols13 commented 9 years ago

I think the biggest problem that we have run into is teachers who never check the calendar icon. So my question is if this will work when they assign E-units that had previous dates entered without checking the calendar?? I am not sure that the alert you put in will help. Again, the teachers for some reason are not clicking that calendar icon - once they do it is obvious that the dates are wrong.

So for example - in my CTE account: logins mindycte pw ellencte I have assigned four E-units in the course Health Science Technology - when I log in as a student: Brian Ash I can only see one ppt. So as the teacher I go in a second time and assign them to the course without adding dates - will the error message pop up?

bguerrettaz commented 9 years ago

I gotcha.

I think part of the problem is that on the assign e-units/PPT's page there isn't any dates at all, because this just a place to purely assign. So no view of old dates would be visible here.

I think all of this needs to occur on the maintain side, do you agree? I see what you are wanting, just trying to think about the best way to implement the changes.

Could you give me a list of URL's where you think this alert would make the most sense, then I can go about seeing if it is doable?

Thanks, Blake

On Mon, Oct 6, 2014 at 8:38 AM, mnichols13 notifications@github.com wrote:

I think the biggest problem that we have run into is teachers who never check the calendar icon. So my question is if this will work when they assign E-units that had previous dates entered without checking the calendar?? I am not sure that the alert you put in will help. Again, the teachers for some reason are not clicking that calendar icon - once they do it is obvious that the dates are wrong.

So for example - in my CTE account: logins mindycte pw ellencte I have assigned four E-units in the course Health Science Technology - when I log in as a student: Brian Ash I can only see one ppt. So as the teacher I go in a second time and assign them to the course without adding dates - will the error message pop up?

— Reply to this email directly or view it on GitHub https://github.com/MyCaert/Issues-Enhancements/issues/89#issuecomment-58017601 .

mnichols13 commented 9 years ago

I don't agree - I think it needs to happen when they assign ppts. Because if they get to the maintain page then they will see the dates - I think the confusion is only when they assign.

http://mycaert.com/Teachers/students/assign-eunits-v2.asp?QuizClassID=25505&OutlineID=18986&Tab=EU&opt=ddl&Scope=StInC

http://mycaert.com/Teachers/students/select-eunits-course-outline.asp?QuizClassID2=25505&Scope=QuizClass&OutlineID=18986

bguerrettaz commented 9 years ago

Ok, the problem with doing it at assignment is there is no date context. The dates are always empty when doing the assigning.

I'm not sure what I would be checking since there aren't any dates in the date dialog boxes.

Blake

On Mon, Oct 6, 2014 at 1:26 PM, mnichols13 notifications@github.com wrote:

I don't agree - I think it needs to happen when they assign ppts. Because if they get to the maintain page then they will see the dates - I think the confusion is only when they assign.

http://mycaert.com/Teachers/students/assign-eunits-v2.asp?QuizClassID=25505&OutlineID=18986&Tab=EU&opt=ddl&Scope=StInC

http://mycaert.com/Teachers/students/select-eunits-course-outline.asp?QuizClassID2=25505&Scope=QuizClass&OutlineID=18986

— Reply to this email directly or view it on GitHub https://github.com/MyCaert/Issues-Enhancements/issues/89#issuecomment-58066617 .

mnichols13 commented 9 years ago

I agree, unless the teacher has previously assigned the same ppts and never wiped out the dates.

bguerrettaz commented 9 years ago

See even then the dates don't show up in those dialog boxes. I just assigned en eunit then went right back to do the same assignment and the date was empty.

On Mon, Oct 6, 2014 at 2:31 PM, mnichols13 notifications@github.com wrote:

I agree, unless the teacher has previously assigned the same ppts and never wiped out the dates.

— Reply to this email directly or view it on GitHub https://github.com/MyCaert/Issues-Enhancements/issues/89#issuecomment-58079728 .

mnichols13 commented 9 years ago

I know its complicated .. I guess due to the fact that we have two ways of assigning E-units? One with dates and one without.

bguerrettaz commented 9 years ago

Yes, that is probably the cause of this.

So how would you like me to proceed?

On Mon, Oct 6, 2014 at 2:51 PM, mnichols13 notifications@github.com wrote:

I know its complicated .. I guess due to the fact that we have two ways of assigning E-units? One with dates and one without.

— Reply to this email directly or view it on GitHub https://github.com/MyCaert/Issues-Enhancements/issues/89#issuecomment-58083643 .

mnichols13 commented 9 years ago

not sure yet - let me play around a little bit more before we start anything

bguerrettaz commented 9 years ago

Sounds good.

On Mon, Oct 6, 2014 at 2:55 PM, mnichols13 notifications@github.com wrote:

not sure yet - let me play around a little bit more before we start anything

— Reply to this email directly or view it on GitHub https://github.com/MyCaert/Issues-Enhancements/issues/89#issuecomment-58084459 .

mnichols13 commented 9 years ago

tabled until Nov 14