libmeta dfgviewer

[datazuul]

libmeta module for DFG-Viewer metadata: Links and Rights.

What about "sonatype-lift" bugs? Should I fix it? Are they gonna be fixed in all other libmeta-libs, too?

[rsteph-de]

Looks good for me so far.

It would be nice, if you check that the files comply with the MyCoRe Java Code Styles. https://www.mycore.de/documentation/developer/codestyle/ Please provide an empty line at the bottom of each file.

Do you plan to provide the Builder implementations to be consistent with the other data model implementations?

Just tell me, when you are done, that I can take it from there (cleanup and implement the missing features, if necessary)

[datazuul]

• Yes, I will reformat code to apply MyCore-Styles.
• Yes, next steps will be to add builder and tests

[sonatype-lift[bot]]

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.[^1]

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/MyCoRe-Org/libmeta/8.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/MyCoRe-Org/libmeta/8.diff | git apply

Once you're satisfied, commit and push your changes in your project. [^1]: You can preview the patch by opening the patch URL in the browser.

[datazuul]

Ready for review, except: What about "sonatype-lift" bugs? Should I fix it? Are they gonna be fixed in all other libmeta-libs, too?

[datazuul]

ok all vulnerabilities fixed

[rsteph-de]

Thank you for fixing the sonatype-liftbot issues. It was integrated to learn and see how useful it's comments are for development.

Finally, would you please add the project / license header comment to all Java files and the DFGViewer-XML schema. copy from here: https://github.com/MyCoRe-Org/libmeta/blob/f3847d8531cef6b6e334d248c4f5127523f6641d/libmeta-mods/src/main/java/org/mycore/libmeta/mods/MODSXMLProcessor.java#L1

After that your PR is ready to be merged.

[datazuul]

ready to merge