search

MyCryptoHQ / MyCrypto

MyCrypto is an open-source tool that allows you to manage your Ethereum accounts privately and securely. Developed by and for the community since 2015, we’re focused on building awesome products that put the power in people’s hands.
https://mycrypto.com
MIT License
1.37k stars 648 forks source link

[beta] accept erc-681 for parity signer #1659

Closed ligi closed 6 years ago

ligi commented 6 years ago

It would be great if the parity signer flow could support erc-681 - currently I am seeing this:

mycrypto_signer_erc681

Background: I want to support this flow with WallETH - but I really do not want to show a QR-Code without context.

ref: https://github.com/paritytech/parity-signer/issues/103

wbobeirne commented 6 years ago

Damn, we gotta make those error messages less obnoxious.

As for 681, that makes a lot of sense for the QR code generated by the site that the app signs, but I don't think it makes sense here in the unlock flow. 681 is for payments, not for identifying an address.

We'll just go along with whatever implementation is in parity-signer & https://github.com/Parity-JS/qr-signer, so I'm going to close this issue to funnel all discussion to the one you linked.

ligi commented 6 years ago

681 is for payments, not for identifying an address.

would you consider using an ERC for addresses? like with prefix "addess-"? I think adding context makes a lot of sense. Otherwise you offload adding context to the user which leads to bad UX

wbobeirne commented 6 years ago

Yeah I think context is always good, especially with QRs. Your point about, at the very least, prefixing with 0x makes a lot of sense. But I'll defer to the Parity team on this, since they're in control of the app and packages used for this flow.

ligi commented 6 years ago

ack & thanks