search

MyCryptoHQ / MyCrypto

MyCrypto is an open-source tool that allows you to manage your Ethereum accounts privately and securely. Developed by and for the community since 2015, we’re focused on building awesome products that put the power in people’s hands.
https://mycrypto.com
MIT License
1.36k stars 650 forks source link

Standardize Checksums and Hex Prefixes for Public/Private Addresses #437

Closed eddiewang closed 6 years ago

eddiewang commented 6 years ago

Currently, when we create a wallet in the production site, the filename is a combination of the date, and the unchecksummed public address without a prefix:

image

The private key is displayed without a hex prefix, like this: image

Since we've moved to the ethereumjs library to handle the wallet creation, it's added minor changes to the way addresses are handled. For example, by default the private key automatically includes a 0x prefix for the key.

image

To maintain compatibility, we plan to manually remove the 0x so that both the paper wallet and the private key displayed on wallet creation.

This is a discussion to see if we should standardize how we choose to display the public key and private keys to the user, and if we should be prefixing the 0x hex identifier for the public and private keys, and if we should be checksumming the public address in the wallet filename.

tayvano commented 6 years ago

This is likely part of a larger discussion within Ethereum community but general unofficial consensus is NO 0x before private keys. Namely to reduce confusion between Addresses or TX hashes that alwlays SHOULD HAVE the proceeding 0x.

Fun fact: TX hashes and private keys are same length. 😱