search

MyEtherWallet / etherwallet

https://vintage.myetherwallet.com
MIT License
2.34k stars 1.71k forks source link

[WIP] French translation #1193

Open DarthJahus opened 6 years ago

DarthJahus commented 6 years ago

Many of the French strings have to be changed. I started reviewing them and correcting/changing the sentences one by one.

There are 674 lines in the file, so the process will need a lot of time. Will subit a Pull Request once done.

I felt like I had to open this discussion in case there are information I have to know before going further.

DarthJahus commented 6 years ago

I need details about this string:

ADD_Radio_5_Path : 'Select HD derivation path',

I have no idea what "HD derivation path" can mean in this context.

MysticRyuujin commented 6 years ago

Ok I might not be 100% here on the wording/logic but if you have a hardware wallet it can store different private keys for different coins in different locations on the device and it's asking you to select the path you want to connect to. I have a Ledger and when I try to connect to it I'm presented with the following screenshot:

image

So basically it's asking you which path on the device you want to open, because one device can contain many different keys for different coins.

Does that help @DarthJahus ?

DarthJahus commented 6 years ago

It does! Thank you very much, @MysticRyuujin.

DarthJahus commented 6 years ago

I got a question about PARITY_GasLimitExceeded.

It says: "Transaction cost exceeds current gas limit. Limit: {}, got: {}. Try decreasing supplied gas.",

If transaction cost exceeds current gas limit, shouldn't we rise the supplied gas?

MysticRyuujin commented 6 years ago

Yes, but I it's up to the user to specify a max gas (note this is not gas price but gas LIMIT) the gas limit is a feature to protect against loops and runaway code.

On Nov 25, 2017 2:15 PM, "Jahus" notifications@github.com wrote:

I got a question about PARITY_GasLimitExceeded.

It says: "Transaction cost exceeds current gas limit. Limit: {}, got: {}. Try decreasing supplied gas.",

If transaction cost exceeds current gas limit, shouldn't we rise the supplied gas?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kvhnuke/etherwallet/issues/1193#issuecomment-346963384, or mute the thread https://github.com/notifications/unsubscribe-auth/AId0Sx-lAjCKXCenEG9zRB196YnMRiQGks5s6HVvgaJpZM4QKHHF .

DarthJahus commented 6 years ago

Understood that. But it says "try decreasing supplied gas". Shouldn't it be "try increasing supplied gas"?

MysticRyuujin commented 6 years ago

I wonder if it's talking about the current block gas limit? I bet that's what it is...which I THINK is 7 million right now.

On Nov 25, 2017 2:46 PM, "Jahus" notifications@github.com wrote:

Understood that. But it says "try decreasing supplied gas". Shouldn't it be "try increasing supplied gas"?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kvhnuke/etherwallet/issues/1193#issuecomment-346965143, or mute the thread https://github.com/notifications/unsubscribe-auth/AId0S-NIS0_hebXMrVBiSvDmcCjLPzApks5s6HyzgaJpZM4QKHHF .