search

MyEtherWallet / etherwallet

https://vintage.myetherwallet.com
MIT License
2.34k stars 1.72k forks source link

Add POA Network as list of nodes #1425

Open rstormsf opened 6 years ago

rstormsf commented 6 years ago

I'm working on PR for MEW to add POA network. I'd like to ask devs for support to let me know list of requirements before I submit a PR.

Current Commit: https://github.com/oraclesorg/wallet/commit/b2387337c6e9752c07bf644b51db3fe4dce22e19 Deployed: https://wallet.poa.network

Questions: Warning for HD paths for Ledger. Please advice on how to fix them. How to set default gasPrice to 1 gwei? Anything else I should know/add before submitting PR?

FYI: We don't intend to run our own version of MEW, we would like to submit PR and destroy our repo.

banteg commented 6 years ago

Tested it with Ledger Nano S, works as expected. Great work!

tayvano commented 6 years ago

We only require that the chain has implemented EIP-155 to prevent replays

jarig commented 6 years ago

Also wonder about HD Paths for Ledger, will there be specific one for the POA?