Closed ugilio closed 8 years ago
I'm going to stop saying we're done / close to done. This is never going to end. 😂
Filed under Taylor is an idiot and will fix
Filed under deal with later
Okay I think I've confirmed all the withdaw DAO, help page, radio buttons, placeholders are done.
I just took a quick look and there are a few error or success messages that have add'l text. I'll do those later. :/
@kvhnuke will need to figure out how to get the translated message in them inline & the possibility of translatin geth messages
New issues after last changes:
For the geth thing, an idea (in pseudocode) might be the following:
gethMsgsToKey = [{'Account does not exist or account balance too low' => 'GETH_NOBALANCE'},
{'Some other error' => 'GETH_SOMEOTHERERROR'}]
gethMsgsTranslated = [{'GETH_NOBALANCE' => 'Account does not exist or account balance too low'}, ...]
gethMsgsTranslated is updated with the correct language. E.g. in Italian the value of GETH_NOBALANCE entry would be 'Il conto non esiste o il saldo è insufficiente'
When receiving an error message from geth, you do a double look-up using these two dictionaries:
translatedMsg = gethMsgsTranslated[gethMsgsToKey[msgReceivedFromGeth]]
which of course for English should not change anything
Also: the disclaimer content is untranslated (but maybe it's on purpose?)
Yeah. I need to get it approved first. It's going to change a bit. And I don't know how were supposed to handle it yet.
Just noticed now that there is no translation for the title of the page ("MyEtherWallet: Open Source JavaScript Client-Side Ether Wallet")
Closing this but moving not-done items to #195
This is a list of things that are still not translated (that is, there is no way for translator to translate ATM). At least, this is what I noticed.
Withdraw DAO:"You are about to withdraw X DAO Tokens for Y ETH. " (no translation)"You are about to withdraw X DAO Tokens to ADDRESS_IN_FIELD_ABOVE for Y ETC." (no translation)"Where do you want your ETC to be sent to?" (no translation)"Withdraw DAO Tokens for ETC" "Withdraw DAO Tokens for ETH" (buttons, no translation)Help page:"If you are on a PC" untranslatedThe radio buttons under "Select the format of your private key:" don't have a matching translation string:"JSON or Keystore File", "Plain Text Private Key" (Select format of your private key:)The placeholder "Private Key" when unlocking a wallet is not translatedWhen selecting a wallet file, the message is always in English "File selected: xxx" (no translation)Error messages coming from geth:"Account does not exist or account balance too low"Maybe it's possible to lookup geth error messages and replace them with a translation, if myetherwallet does provide it?