Closed Pickeringwareltd closed 6 years ago
Do you have the most recent version of the repo @Pickeringwareltd ? Something was breaking this yesterday and have been fixed.
Ahh okay, I have literally just dont what I said above @gamalielhere , i.e. changed the folder and created a pull request as of about 25 minutes ago, should I try again?
Thanks for the quick response, Much appreciated
@Pickeringwareltd Try syncing your fork with the most recent version of mew and try creating the PR again. If it still breaks, I'll my a PR for it.
@gamalielhere ok, I will do and comment back in here afterwards.
Thanks a lot!
Sure thing! Let me know then.
@gamalielhere failed again! See here https://github.com/kvhnuke/etherwallet/pull/1742
@Pickeringwareltd Yeah, I saw it. Let me try making a PR on my end and see if that works.
@gamalielhere Okay, thank you very much!
@Pickeringwareltd Here's the PR. #1743 I took the source abi from etherscan if you don't mind. https://etherscan.io/address/0x5de9f32b2665bb2cdc23bfb51b03e2a2985ecc87#code
@gamalielhere Thank you very much, no of course I dont mind!
Much appreciated for the quick help!
@Pickeringwareltd Sure thing. It looks like it works. I'm assuming it was an issue with the ABI you submitted since my editor was giving me an error. Nonetheless, I'll be merging it later today. It should be in our next release. I'm closing this issue now.
Hi, I have added the AX1 Mining Crowdsale contract to the list of existing contracts:
I have created a pull request and the Travis CI build has failed with error 'gulp prep exited with code 1'! The build information can be found here: https://travis-ci.org/kvhnuke/etherwallet/builds/362271071?utm_source=github_status&utm_medium=notification
The log is here: