MyEtherWallet / etherwallet

https://vintage.myetherwallet.com
MIT License
2.34k stars 1.72k forks source link

Consequences of duplicate reveal bid in ENS #471

Open fortran77 opened 7 years ago

fortran77 commented 7 years ago

I forgot if I had revealed an ENS bid, and did it again just in case. The transaction page on etherscan.io showed this error message in red:

     Warning! Error encountered during contract execution [Bad instruction]

This could mean that I was revealing for the first time and the reveal failed.

Or it could mean that I was revealing the same bid for a second time and [Bad instruction] essentially means duplicate.

So this could be taken as a feature request to add a line somewhere stating what sort of error message to expect when a duplicate reveal is done. And maybe some way of finding out whether or we have already revealed a bid (for those of us who are forgetful).

tayvano commented 7 years ago

I'm fairly certain that the same error appears if you attempt to reveal with bad information that doesn't match any of your bids.

I will need to confirm.

The easiest way to check if you have already revealed is to search yourname.eth in the search bar on etherscan.io and see if you are in the list for that domain.

fortran77 commented 7 years ago

That was a very helpful reply, thanks. Searching for the domain on etherscan.io showed me an "unsealBid" entry in the "Action Taken" column, and the sending address matched mine, so I did successfully reveal the bid.

So that means that a duplicate reveal attempt would in fact be expected to result in the "[Bad instruction]" error that I saw.

tayvano commented 7 years ago

Here is the error that shows when you try to reveal with incorrect information:

Warning! Error encountered during contract execution [Bad instruction]

https://etherscan.io/tx/0x39fa3e945b10fdb5ae755cefdec69943efb39a141ecb758ddf493372094990a1

fortran77 commented 7 years ago

Thanks for the confirmation. I don't know much Solidity, but it seems like the contract ought to print a better error message.