Update swift.yml - Githubissues

MyFormworks / Formworks

Formworks is a framework for building forms from JSON files.

https://myformworks.github.io/Formworks/

MIT License

6 stars 1 forks source link

Update swift.yml #20

Closed cassiaabarbosa closed 4 years ago

cassiaabarbosa commented 4 years ago

Motivation

In order to add SwiftLint in the project, we modified our swift.yml to accept SwiftLint.

Modifications

We modified swift.yml to accept SwiftLint on CI Tests.

Result

We are checking if SwiftLint is working correctly.

Checklist

This PR is

[X] In accordance with our coding principles.
[X] Implementing tests wherever needed and possible.
[X] Free of commented code.
[X] Documented.
[X] Closing an Issue or related to an Issue
[ ] Approved in the CI

Galdineris commented 4 years ago

@cassiaabarbosa Parece que seu PR falhou pois a solução que encontramos só funciona se o ambiente de teste da CI for Linux. @csfar será que é melhor criarmos outro workflow para o SwiftLint? Ou tentar integrar ambos na mesma action?

cassiaabarbosa commented 4 years ago

@Galdineris e @csfar eu vou procurar sobre isso para saber como proceder...