search

MyGUI / mygui

Fast, flexible and simple GUI.
http://mygui.info/
Other
713 stars 205 forks source link

Ogre2.1 branch is long time update #219

Open 36yang opened 3 years ago

36yang commented 3 years ago

Can you update the ogre2.1 branch

36yang commented 3 years ago

There are too many errors compile with Ogre2.2。 need support

Altren commented 3 years ago

I'm not familiar with Ogre2, so the only was I can help you is by telling what was the branch purpose. Someone implemented ogre2 render system and created a branch for it, but since it never was finished it haven't got into master, thus it is outdated now. The plan was to add Ogre2 render system in master, and keep it as well as Ogre1. May be @al2950 , @PieroV or scrawl (hm, scrawl user name is gone) can help you with that.

al2950 commented 3 years ago

Hi

The issue is Ogre 2+ has changed significantly between minor releases making it very difficult to create a single plugin that supports 2.0, 2.1, 2.2 & 2.3, and so this branch has gone a bit stale. Ogre 2+ has become more stable in the last year or so, so it might be worth revisiting this and creating a new branch and starting again making it support Ogre 2.2++. I have a my own version of mygui that compiles with Ogre 2.2 but I would not say its fully functional.

Altren commented 3 years ago

Would it be OK to support only latest Ogre2 version? Having more that one Ogre2 render system sounds crazy and adds too much hussle to maintain that. Or if API is not changing too rapidly may be we can have one version with a few #if OGRE_VERSION checks, that makes it work with all 2.2+ versions.

sercero commented 3 years ago

Also, it might make sense to have Ogre2 as an additional render system instead of a separate branch.

al2950 commented 3 years ago

Would it be OK to support only latest Ogre2 version? Having more that one Ogre2 render system sounds crazy and adds too much hussle to maintain that. Or if API is not changing too rapidly may be we can have one version with a few #if OGRE_VERSION checks, that makes it work with all 2.2+ versions.

Yes... But please note I started to write code to support all Ogre 2.x versions with #if OGRE_VERSION but it got too messy, so it would have to just be 2.2+

Also, it might make sense to have Ogre2 as an additional render system instead of a separate branch.

This branch does actually create an additional render system

36yang commented 3 years ago

Yes, Only Support the lasted 2.2+ is OK, I can wait for it.

cryham commented 2 years ago

It would be great to have official working MyGUI with latest Ogre 2.2+.

cryham commented 2 years ago

I'm trying to get MyGUI working with Ogre 2.3 basing on latest fork from xrgo for Ogre 2.2 https://github.com/yoyTeam/mygui/commits/ogre2.1 Here is the Ogre topic, and my latest runtime error: https://forums.ogre3d.org/viewtopic.php?p=552319#p552319 Edit: It works now.

cryham commented 1 year ago

Just for info, I have a working fork of MyGUI for latest Ogre-Next 3.0: https://github.com/cryham/mygui-next/tree/ogre3 (Windows CMake not fixed yet) Ogre topic with details here: https://forums.ogre3d.org/viewtopic.php?t=96874

Altren commented 1 year ago

I'm willing to accept MR, that would be compatible with master. I recommend rebasing to it, because there is at least one major feature, related to render systems (custom shaders support), that also require some extra code in your branch. Ogre 2 branch was very old.

cryham commented 1 year ago

Yeah, after this commit https://github.com/MyGUI/mygui/commit/e19a011076024ad0c05e8413e6129879099216e8 it will be rather impossible to upmerge changes (to any forks). I think the only way would be to apply fork changes (like our for Ogre-Next) again to the new master of MyGui. Probably means more work. (I still am very far from considering doing it, busy with other stuff).