search

MyGUI / mygui

Fast, flexible and simple GUI.
http://mygui.info/
Other
713 stars 205 forks source link

Key combinations involving CTRL that produce printable characters don't add text to EditBoxes #225

Closed Assumeru closed 2 years ago

Assumeru commented 3 years ago

Certain keyboard layouts put printable characters under Ctrl+Alt+[some other key]. The German layout uses Ctrl+Alt+7 to produce { for example.

This appears to be caused by this check which is used to make shortcuts like Ctrl+V work.

I'm not sure if there would be any downsides to changing that logic to if (valid key combination involving ctrl) { ... } else if (!mModeReadOnly && _char != 0) { add character }.

Related OpenMW issue: https://gitlab.com/OpenMW/openmw/-/issues/5440

Altren commented 3 years ago

Since we are checking for _char != 0 I guess your solution would not cause any issues. You should try to do this yourself and I'll accept PR.