Fix linking with -Wl,--no-undefined

MyGUI / mygui

Fast, flexible and simple GUI.

http://mygui.info/

Other

713 stars 205 forks source link

Fix linking with -Wl,--no-undefined #232

Closed susnux closed 2 years ago

susnux commented 2 years ago

This fixes linking with -Wl,--no-undefined option set, as done by CMake on openSUSE by default.

Link explicitly against SDL2 (for SdlBaseManager) fixing undefined reference to SDL2 functions. Add SDL2::Main target to FindSDL2, as in the the SDL2 CMake config provided by upstream (and most OS install / ship the SDL2Config.cmake by default). Also CMAKE_FIND_PACKAGE_PREFER_CONFIG would use that config instead of the shipped FindSDL2 module.

Altren commented 2 years ago

Could you fix a conflicts, please?

susnux commented 2 years ago

Could you fix a conflicts, please?

Rebased :+1: