search

MyHomeMyData / ioBroker.e3oncan

Viessmann E3 series CAN communication for ioBroker
MIT License
6 stars 2 forks source link

Compatibility check and testing for node.js 22 #65

Closed ioBroker-Bot closed 3 weeks ago

ioBroker-Bot commented 1 month ago

Notification from ioBroker Check and Service Bot

Dear Adapter developer,

Node.js 22 will become the official node.js LTS release October 2024 - see node-releases

So please check your adapter with Node.js 22.

Please add node.js 22 to the adapter testing matrix which is executed on commits. This check is normally controlled by workflow located at .github/workflows/test-and-release.yml. The recommended testmatrix is [18.x, 20.x, 22.x] now. It's ok to test node.js 20.x and 22.x only if there are any technical reasons (i.e. requirements caused by dependencies) to do so.

In any case please set the 'engines' clause in package.json according to the minimum node version used at testing. Please also do this if the adapter is not able to work with certain Node.js versions, so that ioBroker can prevent users from installing the adapter if not compatible. If you detect any incompatibility with node.js 22 please try to fix it and / or let us know if the problem seems to be located at core components.

Please close the issue after you checked it.

Feel free to contact me (@iobroker-bot) if you have any questions.

And THANKS A LOT for maintaining this adapter from me and all users. Let's work together for the best user experience.

your ioBroker Check and Service Bot

@mcm1957 for evidence

Note: If you added node 22 tests already, simply close this issue.

MyHomeMyData commented 1 month ago

When I add 22.x, test-and-release script fails. Problem seems to be linked to socketcan:

npm error code 1
npm error path /home/runner/work/ioBroker.e3oncan/ioBroker.e3oncan/node_modules/socketcan
npm error command failed
npm error command sh -c node-gyp rebuild

Are there any hints how to resolve?

juleq commented 1 month ago

You should probably post the output of the node-gyp command. If you cannot find it, inspect the calling script and then call the offending line manually to get its output.

mcm1957 commented 1 month ago

Info has been provided at iobroker telegram dev channel already. But here for Info too:

https://github.com/MyHomeMyData/ioBroker.e3oncan/actions/runs/10885244181/job/30202383332

MyHomeMyData commented 3 weeks ago

@iobroker-bot recheck

MyHomeMyData commented 3 weeks ago

Problem was caused by referencing error within socketcan package. It's now fixed and node 22 tests have passed.